Zen Lightbox addon [Support Thread]

[DivaVocals]

I like that "cliff's notes" version of github collaboration. :)

While I do agree that jQuery probably doesn't need to be loaded in the way that it has with this plugin since the beginning.
With these new proposals, my concern with pulling latest jQuery from the cdn is that ZLB is based on slimbox which is not really actively developed anymore. There was an update in May (that has not been applied to ZLB) to address jQuery 1.9 compatibility, but the previous one was 3+yrs prior.
So, had we been pulling latest jQuery from CDN all this time, it may have broken everyones ZLB until there was an update to slimbox.

Also, shouldn't we have a fallback to check if !jQuery {load jquery} incase the user has not used a template or other plugin that already has jQuery?

any thoughts on this?

I agree with the fallback code.. it's a BIG problem with sooooo many modules and templates using jQuery and shopowners unwittingly having MULTIPLE versions of jQuery running in their shops.. (which was the inspiration for my contribution)

Couldn't backwards compatibility be mitigated with the jQuery Migrate script??

<script src="http://code.jquery.com/jquery-migrate-1.2.1.js"></script>

[niestudio]

I agree with the fallback code.. it's a BIG problem with sooooo many modules and templates using jQuery and shopowners unwittingly having MULTIPLE versions of jQuery running in their shops.. (which was the inspiration for my contribution)

Couldn't backwards compatibility be mitigated with the jQuery Migrate script??

<script src="http://code.jquery.com/jquery-migrate-1.2.1.js"></script>

Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?

Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
Going forward it could be good though.

[DivaVocals]

Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?

I believe that v1.6 (though I haven't looked at the gibhub lately) is going to do JUST THAT.. Then there would be no NEED for plugin authors to have to include jQuery files which would also eliminate the issue with multiple jQuery versions being loaded on a shop..

It's a path WordPress also took in recent versions so that plugin developers wouldn't have to include jQuery in their plugins. Eliminates the number of plugin clashes due to conflicting versions of jQuery loading at once on a site..

Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
Going forward it could be good though.

Well I've used it with Zen Lightbox with no issues.. let me find the site and post the URL.. Here's the gihub for the jQuery Migrate script: https://github.com/jquery/jquery-migrate/#readme

Edited to add: http://laserdiscvault(dot)com/
CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..

[Design75]

haha , you make one little change in code and get almost 2,5 pages of reading in return .

The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

[niestudio]

haha , you make one little change in code and get almost 2,5 pages of reading in return .

The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

has happened this way a lot over the years.

I'll go ahead and update to Slimbox 2.05 then we can safely load jQuery latest.

[niestudio]

haha , you make one little change in code and get almost 2,5 pages of reading in return .

should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?

[niestudio]

Edited to add: http://laserdiscvault(dot)com/
CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

[DivaVocals]

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..

[DivaVocals]

I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..

Done.. take a look now.. Update the jQuery and jQuery Migrate versions.. Lightbox still works like a champ..

should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?

I would agree with this move..

[Design75]

I would agree with this move..

I would also agree