Edit Orders v4.0 Support Thread

swguy:

Suggestion on admin/includes/classes/editOrders.php

instead of

$ot_tax_class = constant ($ot_tax_class_name);

> 
> use 
> 
> ```
        $ot_tax_class = null;
        if (defined($ot_tax_class_name)) {
           $ot_tax_class = constant ($ot_tax_class_name);
        }

to prevent a PHP Warning in case the tax class doesn't exist.
Thanks @swguy; I've created an issue in the Edit Orders GitHub repository to track. Could you provide details regarding how to reproduce the error?

1. Install Better Together and add a discount.
2. Run an order that gets this discount.
3. Edit that order.

Latest EO also has a bug which shows up editing an order which uses an order total module with recalculate taxes = Standard. You can dup with Group Pricing.

Original Order:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.39
Tax 7.0%: $31.44
Total: $477.05

After EO:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.04 (** error)
Tax 7.0%: $31.44
Total: $473.91 (** error)

swguy:

Latest EO also has a bug which shows up editing an order which uses an order total module with recalculate taxes = Standard. You can dup with Group Pricing.

Original Order:
Sub-Total: $499.00S
Shipping: $0.00
Group Discount: -$53.39
Tax 7.0%: $31.44
Total: $477.05

After EO:
Sub-Total: $499.00S
Shipping: $0.00
Group Discount: -$53.04 (** error)
Tax 7.0%: $31.44
Total: $473.91 (** error)
@swguy, any idea where that trailing **S **on the sub-total is coming from? I'm guessing that that could be part of the issue.

Sorry - that was copy & paste cruft. Fixed.

swguy:

Latest EO also has a bug which shows up editing an order which uses an order total module with recalculate taxes = Standard. You can dup with Group Pricing.

Original Order:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.39
Tax 7.0%: $31.44
Total: $477.05

After EO:
Sub-Total: $499.00
Shipping: $0.00
Group Discount: -$53.04 (** error)
Tax 7.0%: $31.44
Total: $473.91 (** error)
@swguy, would you enable EO debug, update that order and send me the generated EO log file via direct email?

Just completed and sent.

... and I've replicated the issue locally. I'll post back when I've identified the root-cause.

Fix needed for virtual orders with no shipping address: such orders will show the message WARNING_ADDRESS_COUNTRY_NOT_FOUND
("Warning: One or more of the customer address fields contains a country name unknown to Zen Cart...")

edit_orders.php line ~ 677 change

      if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
        !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) ||
        !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])) {
        $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
      }

to

      if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
        !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country'])) {
        $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
      } else if ($order->delivery !== false && !empty($order->delivery['country'])) {
        if (!is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])) {
           $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
        }
      }

@swguy, what version of EO are you running? That message being displayed for virtual orders was corrected last year via this GitHub commit for EO 4.1.6.

The code segment that you refer to currently reads (edit_orders.php, line 623):

        if (!$eo->eoOrderIsVirtual ($order) &&
               ( !is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
                 !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) ||
                 !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country']) )) {
            $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
        }

Ah ok thanks I have 4.1.5-beta2.

swguy:

Ah ok thanks I have 4.1.5-beta2.
Current version is 4.2.3.

I've just submitted v4.3.0 of Edit Orders to the Zen Cart plugins for review. That release contains changes associated with the following GitHub issues:

#50: Correct product.products_ordered calculation (thanks @siliconforks!).
#52: Correct PHP warning when an order-total doesn't include a "TAX_CLASS" setting.
#53: Additional notifiers for address-field insertions.
#54: Invalid value used in "Mock Cart" processing.
#55: Correct PHP "notify" issues.
#56: Correct order-total calculations when order-totals re-compute tax (e.g. group pricing), as reported by @swguy here.
#57: Properly report missing notifiers

I'll post back here once the download is available.

Note on #56: Users must remember to manually press the button.

swguy:

Note on #56: Users must remember to manually press the button.
Actually, it's changed from the prototype I sent you. The processing now has a checkbox field which, if set, causes the order's totals to be reset rather than a separate button. You can configure the default value for that checkbox field in Configuration->Edit Orders.

:thumbsup:

lat9:

I've just submitted v4.3.0 of Edit Orders to the Zen Cart plugins for review. That release contains changes associated with the following GitHub issues:

#50: Correct product.products_ordered calculation (thanks @siliconforks!).
#52: Correct PHP warning when an order-total doesn't include a "TAX_CLASS" setting.
#53: Additional notifiers for address-field insertions.
#54: Invalid value used in "Mock Cart" processing.
#55: Correct PHP "notify" issues.
#56: Correct order-total calculations when order-totals re-compute tax (e.g. group pricing), as reported by @swguy here.
#57: Properly report missing notifiers

I'll post back here once the download is available.
That was quick! It's now available for download!

Hi

Just updated to latest version. All works great (as expected!).

A wish list item for future versions/updates - not sure how hard it would be to incorporate - our site is UK based and we use 'state' (changed to 'County') as a dropdown which must be selected by a customer for UK Royal Mail shipping to be applied. Is it possible to have the 'state' field as a dropdown on the edit orders page so that we can ensure the correct state/county is selected?

Thanks

Mark https://www.johnwoodsmotorcare.co.uk/Shop | https://www.johnwoodsmotorcare.net

Sounds like a good idea; I've created an issue in Edit Orders' GitHub repository so that I don't lose the request!

lat9:

Sounds like a good idea; I've created an issue in Edit Orders' GitHub repository so that I don't lose the request!

@lat9 when i have some time, i will take a look at this new release, and compare it to all of the changes i have done over the years.

without even thinking too much about it, i remember order total calculations, tax calculations (especially when using a different tax module) and changing line item quantities have been problematic. the last item caused me a bunch of grief, as the deletion of a record in orders_products and re-creation of a new record in that same table seems like overkill for changing the quantity from 2 to 3. and despite it being overkill, it overlooks the idea that a store owner could have additional fields in that table due to modifications, and that significant data gets lost. i am not sure if this version addresses that issue. but considering i do have clients using this add-on, and with your name on it, i will try and spend a bit of time on it.

if i find any issues that i think are of merit, lmk if you would prefer me to add something onto your github or if you would prefer to discuss them here.

best.