Edit Orders v4.0 Support Thread

Here is the debugging message: [19-Jul-2016 19:35:17 America/Phoenix] PHP Parse error: syntax error, unexpected T_STRING in /home/content/93/13964793/html/eureka/includes/languages/english/index.php on line 52

Interestingly, the path that it's specifying has an old filename. the site name "eureka" was renamed "rosswells" last spring.

cindygordon:

Here is the debugging message: [19-Jul-2016 19:35:17 America/Phoenix] PHP Parse error: syntax error, unexpected T_STRING in /home/content/93/13964793/html/eureka/includes/languages/english/index.php on line 52

Interestingly, the path that it's specifying has an old filename. the site name "eureka" was renamed "rosswells" last spring.
That's weird, since that file isn't part of the*** Edit Orders*** distribution.

The debug file is from July 2016 !!!!
There should be a newer one.

lat9:

That's weird, since that file isn't part of the*** Edit Orders*** distribution.

You're right!! I thought it was sorting by date, but it wasn't.

Here is the most recent one:

[12-Nov-2017 23:52:14 America/Phoenix] PHP Fatal error: Cannot redeclare class Vinos\VinosAutoload in /home/content/93/13964793/html/rosswells/includes/classes/VinosAutoload.php on line 19

Design75:

The debug file is from July 2016 !!!!
There should be a newer one.

cindygordon:

You're right!! I thought it was sorting by date, but it wasn't.

Here is the most recent one:

[12-Nov-2017 23:52:14 America/Phoenix] PHP Fatal error: Cannot redeclare class Vinos\VinosAutoload in /home/content/93/13964793/html/rosswells/includes/classes/VinosAutoload.php on line 19
@cindygordon granted me temporary FTP access to her site and I found a couple of things:

1. The storefront /includes directory had been mistakenly uploaded to the /admin/includes along with the /admin directory changes. I'll note that this is easy to do (I've only done it a gazillion times myself), especially when there are both storefront and admin changes associated with a plugin.
2. The store's Zen Cart version is 1.5.1, which is not compatible with current versions of EO.:(

I simply removed the EO-related files and restored the (thankfully only 2) core-file overwrites to their ZC 1.5.1 version so she's back-in-business and now looking to upgrade prior to the EO installation.

lat9:

@cindygordon granted me temporary FTP access to her site and I found a couple of things:

2. The storefront /includes directory had been mistakenly uploaded to the /admin/includes along with the /admin directory changes. I'll note that this is easy to do (I've only done it a gazillion times myself), especially when there are both storefront and admin changes associated with a plugin.

3. The store's Zen Cart version is 1.5.1, which is not compatible with current versions of EO.:(

I simply removed the EO-related files and restored the (thankfully only 2) core-file overwrites to their ZC 1.5.1 version so she's back-in-business and now looking to upgrade prior to the EO installation.

Lat9, you are my hero, thank you SOOOOO much!!
Obviously completely my fault, not a reflection on Edit Orders.
Looking forward to upgrading the cart and reinstalling EO properly. Thank you again!!

Hello,
I just discovered an issue with this great plugin that I was hoping for some guidance. I had to remove the shipping charge for one of my orders which is taxable and although it shows the shipping amount as zero, the invoice total still includes the original tax amount on shipping.

@allmart, Did you tick the "Recalculate Totals" box before updating?

lat9:

@allmart, Did you tick the "Recalculate Totals" box before updating?
i have the Reset Totals on Update ticked in configuration. see below

@allmart, please generate an EO debug-log for that order; I'll send you my direct email via PM.

1. Navigate to your admin's Edit Orders page for the order in question.
2. Make sure that the file /logs/edit_orders/debug_edit_orders_xx.log (where xx is the order-id) is deleted.
3. Click the "Update" button on the EO screen.
4. Grab that debug-log and email it to me for analysis.

Thanks, @allmart. I've created a tracking issue in EO's GitHub repository. It turns out that the issue surfaces when removing a shipping-cost (i.e. setting that value to 0) when that shipping is taxed.

I've just submitted EO v4.3.1 to the Zen Cart plugins for review; I'll post back here once it's available for download.

That version contains changes associated with the following issues, as identified on the plugin's GitHub repository:

#60: Correct totals' calculations when shipping is taxed and the store displays prices with tax.
#62: Correct multiple messages issued on initial plugin installation.
#63: Correct customer-information over-preparation.
#64: Correct totals' calculations when shipping is taxed, but none of the products are.

lat9:

I've just submitted EO v4.3.1 to the Zen Cart plugins for review; I'll post back here once it's available for download.

That version contains changes associated with the following issues, as identified on the plugin's GitHub repository:

#60: Correct totals' calculations when shipping is taxed and the store displays prices with tax.
#62: Correct multiple messages issued on initial plugin installation.
#63: Correct customer-information over-preparation.
#64: Correct totals' calculations when shipping is taxed, but none of the products are.
v4.3.1 is now available for download from the Zen Cart plugins: https://www.zen-cart.com/downloads.php?do=file&id=1513

Just installed EO 4.3.1 on ZC 1.5.5e and starting to test. I'm not sure what should happen if a new product is added to the order wrt the shipping charge. Should the shipping charge be automatically updated? Or must it be manually updated? I'm using the Flat Rate shipping module and the EO recalculate totals checkbox is checked (default in config).

Also, if an order was created with another shipping module, store pickup in my case, should ALL other shipping methods that apply to that shipping zone be available in the shipping pull down menu? In my case, the Flat Rate module is not present.

Finally, I've noticed discussion of an edit orders log in other posts. How do you activate the edit orders logging process?

Thank you!

Dave224:

Just installed EO 4.3.1 on ZC 1.5.5e and starting to test. I'm not sure what should happen if a new product is added to the order wrt the shipping charge. Should the shipping charge be automatically updated? Or must it be manually updated? I'm using the Flat Rate shipping module and the EO recalculate totals checkbox is checked (default in config).

Also, if an order was created with another shipping module, store pickup in my case, should ALL other shipping methods that apply to that shipping zone be available in the shipping pull down menu? In my case, the Flat Rate module is not present.

Finally, I've noticed discussion of an edit orders log in other posts. How do you activate the edit orders logging process?

Thank you!
EO does not recalculate shipping; if the addition of a product to the order requires that shipping be updated, that's a manual process.

The shipping dropdown-selection "should" include all available shipping options.

To enable the EO debug, head over to your admin's Configuration->Edit Orders to change that setting. The debug creates file(s) in the /logs/edit_orders directory, one-per-order: debug_edit_orders_xx.log, where ***xx ***is the order number.

Thanks! When you said logging was a config item, I figured there was a problem in installation. All shipping modules now appearing in drop down.

Shipping tax is entered in percent (10.0 for 10%), correct?

What tax adjustments should EO make if a misc cost or a one time discount is applied and the order qualifies for tax?

Dave224:

Thanks! When you said logging was a config item, I figured there was a problem in installation. All shipping modules now appearing in drop down.

Shipping tax is entered in percent (10.0 for 10%), correct?

What tax adjustments should EO make if a misc cost or a one time discount is applied and the order qualifies for tax?
Shipping tax is entered as a full value (as you indicated). EO makes no tax adjustments for misc-cost or one-time-discount additions, you've got to "bake" any tax-related updates into the addition/subtraction.

Hmmm. That's not what I'm seeing. I get a tax increase for a misc cost. No effect on tax for a one time discount. Can you suggest a place to look for the problem? ot_misc_cost??? OE somewhere?? ot_tax???

Thanks for your rapid responses!

Dave224:

Hmmm. That's not what I'm seeing. I get a tax increase for a misc cost. No effect on tax for a one time discount. Can you suggest a place to look for the problem? ot_misc_cost??? OE somewhere?? ot_tax???

Thanks for your rapid responses!
I'll need to look at the innards ... tomorrow ... to give you an accurate answer.

Actually, the current code allows a lot of flexibility. The Misc Cost will accept positive and negative cost adjustments. When the cost adjustment is negative, a credit is applied, and the tax is reduced by the tax on the cost adjustment. For a positive cost adjustment, the total increases by the adjustment plus the tax on the adjustment. Neglecting quantity and group discounts, this behavior is the same as increasing or decreasing the price of a taxable product.

Unfortunately, the one-time discount adjustment always calculates a discount for both positive and negative adjustments. If the sign were honored, you could use one-time discount for after-tax (non-taxed) credits and after-tax costs.

Because I want the flexibility of both before and after tax credits and costs, I'm going to search for where the one-time discount input is processed and see if I can get it to honor the adjustment sign. Rewording some of the displayed text may also be helpful.

Dave