Edit Orders v4.0 Support Thread

@Dustie

I don't even see what you are referring to in the configuration settings?!!

Only see the following:

Edit Orders Version (4.3.4)
Reset Totals on Update — Default (on)
Use a mock shopping cart? (false)
Strip tags from the shipping module name? (true)
Debug Action Level (1)

Should I also see 'Product Price Calculation'?

lat9:

@jvdd, there was most likely an associated /logs/myDEBUG-adm-*.log file on/around the time of that EO log. My guess is that the processing is running out of memory, but a log will 'say' for sure.

Remember, if you're posting an admin log that it will contain your store's secret admin directory name, so be sure to xxx-out any path information before posting.

Sorry, I apologize for not mentioning a couple of logs before the EO issue mentioned. They have been resolved and therefore archived and reset. I don't believe they are related.

[30-May-2019 12:10:46 America/Toronto] PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 72 bytes) in /.../.../.../.../developers_tool_kit.php on line 164

and

[30-May-2019 16:51:16 America/Toronto] Request URI: /index.php?main_page=checkout_confirmation, IP address: XX.XX.XX.XXX
#1  currencies->display_price() called at [/.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php:201]
#2  require(/.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php) called at [/.../.../.../includes/templates/.../common/tpl_main_page.php:183]
#3  require(/.../.../.../includes/templates/.../common/tpl_main_page.php) called at /.../.../.../index.php:97]

[30-May-2019 16:51:16 America/Toronto] PHP Warning:  Missing argument 2 for currencies::display_price(), called in /.../.../.../includes/templates/.../templates/tpl_checkout_confirmation_default.php on line 201 and defined in /.../.../.../includes/classes/currencies.php on line 123

@jvdd, neither of those logs is EO related. The first is from the "Developers' Tool Kit" and the other is from the storefront checkout_confirmation page.

Hi just tried installing this on 1.5.6a, but I get this message when I try to use it:
The store's zen_add_tax function must be updated to enable Edit Orders' use
Do I need to update to 1.5.6b?

Nope, just provide that update to /admin/includes/functions/general.php, as identified in the readme's Installation->Changes to zen_add_tax tab.

Thanks for the quick response, for some reason I totally missed that tab!

Now works great.
One minor thing, we use the Invoice payment method module, which uses group pricing
I think that is why I am unable to change the unit price of a product.
No big deal, I don't see us needing to do that anyway.
Thanks for a great Add on!

lat9:

@jvdd, neither of those logs is EO related. The first is from the "Developers' Tool Kit" and the other is from the storefront checkout_confirmation page.

Ya, Just wanted to be thorough and provide enough info regarding the logs (ie. don't see anything relating to EO) :blush:

wyliecoyoteuk:

Now works great.
One minor thing, we use the Invoice payment method module, which uses group pricing
I think that is why I am unable to change the unit price of a product.
No big deal, I don't see us needing to do that anyway.
Thanks for a great Add on!
I'm not familiar with that payment module, but changing the EO configuration so that you can enter prices Manually should allow you to provide those price overrides.

Hi,

I've just updated this module from the previous version, and have encountered a major issue. The site is running on ZC 1.5.5e, and one of the additional modules installed is Dual Pricing which, as you may know, allows both a wholesale and retail price to be set for products. The customer gets to see the correct price based on a customer status setting.

In testing, the new version seems to work correctly in other areas, but when an order for a wholesale customer is edited to add an additional product to the order, the additional product is added using the retail price. This make the new version totally un-useable on the site. This is the second time I have installed the update, and after checking all the merges.

I might also add that Super Orders is also installed, that I found that trying to merge zc155/YOUR_ADMIN/orders.php the existing version a nightmare beyond my capabilities, so I used the current version on the site.

I would appreciate any help in resolving the retail/wholesale pricing issue. I might add that this feature works correctly with previous versions of Edit Orders.

donw:

Hi,

I've just updated this module from the previous version, and have encountered a major issue. The site is running on ZC 1.5.5e, and one of the additional modules installed is Dual Pricing which, as you may know, allows both a wholesale and retail price to be set for products. The customer gets to see the correct price based on a customer status setting.

In testing, the new version seems to work correctly in other areas, but when an order for a wholesale customer is edited to add an additional product to the order, the additional product is added using the retail price. This make the new version totally un-useable on the site. This is the second time I have installed the update, and after checking all the merges.

I might also add that Super Orders is also installed, that I found that trying to merge zc155/YOUR_ADMIN/orders.php the existing version a nightmare beyond my capabilities, so I used the current version on the site.

I would appreciate any help in resolving the retail/wholesale pricing issue. I might add that this feature works correctly with previous versions of Edit Orders.
I'd be interested to know what the "previous version(s)" were, since I've never seen an integration between EO and Dual Pricing.

I didn't suggest there is an "integration" between the modules. Just that both modules have been installed on the site without any problems, and certainly since EO 4.3.3.

donw:

I didn't suggest there is an "integration" between the modules. Just that both modules have been installed on the site without any problems, and certainly since EO 4.3.3.
What are the EO 4.3.3 configuration settings?

4.3.5 is installed and functions correctly, other than the tax calculation issue. Configuration settings are:

Reset Totals on Update - Default on
Strip tags... true
Debug action level 0
Product Price Calculation - Method Manual
Product Price Calculation - Default Manual
Status-history Display order Asc
Status-update..... Email
Super Orders Module Switch True

@donw, having re-read your initial posting (#1407), I'll note that when a product is added to an order via EO that the in-store price calculations are always used. If the price returned for your dual-pricing-enabled customers, I'll have to suggest that somewhere that ability to apply those pricing alternations in the admin have 'disappeared'.

Additionally, those configuration settings that you posted in #1411 are for EO v4.4.0 (that's when the Status-history/Display order and update-email settings were introduced).

Are you saying that the Dual-pricing worked for v4.3.5 and not for v4.4.0? Please advise.

Ok. To address the issue of EO configuration settings first. The EO configuration page shows version 4.3.5, and I'm assuming those option have remained as, after discovering the problem with pricing after installing 4.4.02, I simply reverted back to the 4.3.5 versions of the site files, which possibly was not the best way of doing things

Yes, I am saying that Dual Pricing worked correctly, and still does, with 4.3.5, and does not with 4.4.02.

donw:

Ok. To address the issue of EO configuration settings first. The EO configuration page shows version 4.3.5, and I'm assuming those option have remained as, after discovering the problem with pricing after installing 4.4.02, I simply reverted back to the 4.3.5 versions of the site files, which possibly was not the best way of doing things

Yes, I am saying that Dual Pricing worked correctly, and still does, with 4.3.5, and does not with 4.4.02.
@donw, I'm quite befuddled as I don't understand how the Dual Pricing works with 4.3.5. What version of Dual Pricing and where did you get it?

Version 2.1.7(a) from the Zencart site.

donw:

Version 2.1.7(a) from the Zencart site.
Thanks, I'll look into that later this week.

lat9:

Thanks, I'll look into that later this week.
I've taken that look and still don't understand how the dual-pricing ever worked with EO (v4.3.5 or whatever). Looking at the 2.1.7a version, its changes to the /admin/includes/functions/functions_prices.php look "off" to me, specifically zen_get_products_special_price which is used by EO:

//get specials price or sale price
  function zen_get_products_special_price($product_id, $specials_price_only=false) {
    global $db;
    $product = $db->Execute("select products_price, products_model, products_priced_by_attribute from " . TABLE_PRODUCTS . " where products_id = '" . (int)$product_id . "'");

    if ($product->RecordCount() > 0) {
//  	  $product_price = $product->fields['products_price'];
      $product_price = zen_get_products_base_price($product_id);
    } else {
      return false;
    }

[B]// Dual Pricing start
    if ($product->RecordCount() > 0) {
//  	  $product_price = $product->fields['products_price'];
      $product_price = zen_get_products_base_price_w($product_id);
    } else {
      return false;
    }
// Dual Pricing end[/B]

    $specials = $db->Execute("select specials_new_products_price from " . TABLE_SPECIALS . " where products_id = '" . (int)$product_id . "' and status='1'");
    if ($specials->RecordCount() > 0) {
//      if ($product->fields['products_priced_by_attribute'] == 1) {
        $special_price = $specials->fields['specials_new_products_price'];
    } else {
      $special_price = false;
    }

If the specified product exists, that section of code will never execute, since its condition is satisfied by the if/else clause the precedes it.