Edit Orders v4.0 Support Thread

twitchtoo:

Thanks for the info, one of the problems is that the order total modules/classes are not being considered when recalculating the proper order total.

From what I can see they are hard coded filters. So, when an order is processed if there are any name changes or variations or alternate values in the class beyond what EO has written they will not be included but what's worse is the code will erase the entire 'old' data and only add the new.

For example: Reward Points class = ot_reward_points_display will not be recognized as there is no code identifying what is in the order data dynamically then deciding what to do with it without just bulldozing the new data in.

That explains also why reward points is not being recalculated during EO updates.
FWIW, I just verified that the ot_loworder fee is added/subtracted when the order is updated on a fresh zc155f/eo451 installation.

From what I've seen of the Reward Points plugin, it's got too many tentacles into the cart-related processing to allow it to interoperate with Edit Orders.

I'm not sure what you mean by "hard coded filters"; there are some processing variations for some order-totals but for the most part, if an order-total is installed it's given the opportunity to run and make its changes to the order itself.

Thanks lat9, I'll get them all working together later today.

twitchtoo:

Thanks lat9, I'll get them all working together later today.
Excellent. If you want to share your changes, I'll be happy to include them in a future EO release.

EO 4.5.0
When I attempt to add "Edit Orders" to non-SuperUser admin profiles, the non-SuperUser Admin user gets the message

If I missed the fix or setting, it's ok to tell me to look a bit harder. :-)

Sorry, your security clearance does not allow you to access this resource.

Please contact your site administrator if you believe this to be incorrect.

Sorry for any inconvenience.

Another myDEBUG. Sorry, I can find all the lines mentioned but it is mostly cross-eyed visions.

[06-Apr-2020 13:09:46 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  usps->usps_translation() called at [/home/chainwea/public_html/includes/modules/shipping/usps.php:159]
#2  usps->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#3  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#4  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1555]
--> PHP Warning: Illegal string offset 'iso_code_2' in /home/chainwea/public_html/includes/modules/shipping/usps.php on line 1991.

[06-Apr-2020 13:09:46 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  usps->usps_translation() called at [/home/chainwea/public_html/includes/modules/shipping/usps.php:159]
#2  usps->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#3  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#4  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1555]
--> PHP Warning: Illegal string offset 'iso_code_2' in /home/chainwea/public_html/includes/modules/shipping/usps.php on line 2005.

[06-Apr-2020 13:09:46 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  freeoptions->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#2  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#3  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1555]
--> PHP Warning: Illegal string offset 'id' in /home/chainwea/public_html/includes/modules/shipping/freeoptions.php on line 35.

[06-Apr-2020 13:09:47 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  usps->usps_translation() called at [/home/chainwea/public_html/includes/modules/shipping/usps.php:159]
#2  usps->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#3  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#4  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1613]
--> PHP Warning: Illegal string offset 'iso_code_2' in /home/chainwea/public_html/includes/modules/shipping/usps.php on line 1991.

[06-Apr-2020 13:09:47 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  usps->usps_translation() called at [/home/chainwea/public_html/includes/modules/shipping/usps.php:159]
#2  usps->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#3  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#4  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1613]
--> PHP Warning: Illegal string offset 'iso_code_2' in /home/chainwea/public_html/includes/modules/shipping/usps.php on line 2005.

[06-Apr-2020 13:09:47 America/Los_Angeles] Request URI: /greeN-JdH-shruB/edit_orders.php?selected_box=customers&status=5&page=1&oID=920110&action=edit, IP address: 98.146.164.107
#1  freeoptions->__construct() called at [/home/chainwea/public_html/includes/classes/shipping.php:63]
#2  shipping->__construct() called at [/home/chainwea/public_html/greeN-JdH-shruB/includes/functions/extra_functions/edit_orders_functions.php:1635]
#3  eo_get_available_shipping_modules() called at [/home/chainwea/public_html/greeN-JdH-shruB/edit_orders.php:1613]
--> PHP Warning: Illegal string offset 'id' in /home/chainwea/public_html/includes/modules/shipping/freeoptions.php on line 35.

RixStix:

EO 4.5.0
When I attempt to add "Edit Orders" to non-SuperUser admin profiles, the non-SuperUser Admin user gets the message

If I missed the fix or setting, it's ok to tell me to look a bit harder. :-)

**Dummy here looked a bit harder. ** Found the 2nd "edit orders" checkbox under CUSTOMERS which had not yet been checked in the non-superuser admin profile. The one under Configuration had been checked in the non-superuser admin profile.

Edit an order

Click update (not sure if there is a difference dependent upon which of the 2 Update buttons are clicked)
Green banner that order has been edited.
Return to order
Edited fields (product name and model) are not changed

the myDebug file is generated

Order had been in a 'cancelled' status (5)
Edited status back to 'processing' prior to making any order edits.

RixStix:

Edit an order

Click update (not sure if there is a difference dependent upon which of the 2 Update buttons are clicked)
Green banner that order has been edited.
Return to order
Edited fields (product name and model) are not changed

the myDebug file is generated

Order had been in a 'cancelled' status (5)
Edited status back to 'processing' prior to making any order edits.
There's now a configuration setting that controls EO's product-handling. That defaults to automatic, where the product-related information is gathered 'automatically' and overrides the manual entry. Sounds like you want to change the default from "Automatic" to "Manual".

In EO Configuration, I see what appears to be related to automatic price calculations, but nothing related to not allowing the editing of a product description or model number.

Maybe I am misunderstanding the intended functionality. If a product has attributes, the attribute has a pulldown box which can be changed. Product name and model only appears as a text box. I can edit/change an attribute. I cannot type a different product name or model number. Not all products have product numbers.

RixStix:

In EO Configuration, I see what appears to be related to automatic price calculations, but nothing related to not allowing the editing of a product description or model number.

Maybe I am misunderstanding the intended functionality. If a product has attributes, the attribute has a pulldown box which can be changed. Product name and model only appears as a text box. I can edit/change an attribute. I cannot type a different product name or model number. Not all products have product numbers.
The product-pricing (automatic vs manual) also affects the product name and model. When automatic, the name/model is pulled from the database; when manual, input is accepted and stored.

I'm just going to remove EO

That is the only thing that I can do within my current skillset to prevent the debug files from being generated and hopefully removing it will also restore functionality to Square. I am not saying there is a problem with EO because it is probably something that I did or didn't do.

you should change your admin directory name since you've put it out there for all to see

Ooops

thanks

Next to the update button on the left, we have

Reset totals prior to update? (checkbox) Note: Pricing for products will be automatically calculated without "specials" pricing.

I wonder if it would be better to put each of these on a separate line? The current layout could be confusing for new people.

Hi, using Edit Orders 4.5.1 on Zen Cart 1.5.6c, at
https://www.proteawines.jp
with Paypal Express Checkout enabled and working fine.
My store and I are both based in Tokyo, Japan.

I have edited my first order, the payment is on hold pending delivery courtesy of Paypal (since the payer is in Japan, outside the US).
This has always worked before, so this is not a problem, payment goes through after delivery (I supply tracking information).

I added a miscellaneous item (small addition for refrigerated shipping requested by customer after she placed the order).
However, this does not seem to change the pending payment amount from Paypal for the order.
So the customer now has an order in Zen Cart not matching what Paypal says will be paid.
Or will Paypal do an update on the order when they fulfill their payment after delivery?

If there order had been changed materially (i.e., changes to the products, or a completely different shipping method), would that update Paypal right away?

Sorry for the questions, I could not find an answer searching this thread, reading the docs, or via Google.

Changes to an order that result in a difference in payment are the responsibility of the store-owner to rectify. Edit Orders has no 'play' in updating the payment-provider to refund or collect additional funds based on the order's value changing.

Thanks for clearing that up, much appreciated.
I guess in Zen Cart the way to do that with the Express Checkout module is to give a refund, and ask the buyer to make the new payment.
Presumably that works for Square as well and other card processors.
If there is another way that people tend to use, I would love to know also.

Hello!

After I edit one order all prices in my Zencart admin backend are shown without taxes.

If I logout and then login taxes are back.

I believe this is something related to session.

Where could be the problem?

jeanjean88:

Hello!

After I edit one order all prices in my Zencart admin backend are shown without taxes.

If I logout and then login taxes are back.

I believe this is something related to session.

Where could be the problem?
You haven't given me much to work with. What's the Zen Cart version, the EO version and other plugins in use on the admin?

What are your store's settings for My Store->Display prices with tax and Display prices with tax in admin?

Zencart v1.5.1

EO 4.1.4

I don't have related plugins in the admin

Display Prices with Tax: true
Display Prices with Tax in Admin: true

The only thing I did notice is that if I comment the following line in functions/edit_orders_functions.php the error doesn't happen anymore, unless I add a product (so if I simply update address or prices it doesn't happen)

function eo_get_order_by_id($oID) {
	global $db, $order;

	// Retrieve the order
	$order = new order($oID);

	// Add some required customer information for tax calculation
	// The next method has been modified to add required info to the
	// session and global variables.

	// zen_get_tax_locations();   <============================= THIS COMMENTED