Edit Orders v4.0 Support Thread

swguy:

admin/includes/classes/editOrders.php lines 270, 274: should $this->shipping_tax_rate be cast as a float in case it's null?
(Getting SQL error on line 270)
It's taken a long time to get all those other float-casts out of EO (trying to get rid of those penny-off calculations), but I'll update this section of the class' *initializeOrderShippingTax *method:

        switch ($action) {
            case 'update_order':
                [B]$this->shipping_tax_rate = $_POST['shipping_tax'];[/B]
                $order->info['shipping_tax'] = $this->calculateOrderShippingTax(true);
                break;
            case 'add_prdct':
                $this->shipping_tax_rate = $tax_rate->fields['shipping_tax_rate'];
                $order->info['shipping_tax'] = $this->eoRoundCurrencyValue(zen_calculate_tax($order->info['shipping_cost'], $this->shipping_tax_rate));
                break;
            default:
                $this->shipping_tax_rate = $tax_rate->fields['shipping_tax_rate'];
                $order->info['shipping_tax'] = $this->calculateOrderShippingTax(false);
                break;
        }

to sanitize that value on entry.

See this GitHub issue for follow-on: https://github.com/lat9/edit_orders/issues/157

As an alternative, you could not do the update when the value is null. But I'm ok with either solution. Thanks!

lat9:

It's taken a long time to get all those other float-casts out of EO (trying to get rid of those penny-off calculations), but I'll update this section of the class' *initializeOrderShippingTax *method:

    switch ($action) {
        case 'update_order':
            [B]$this->shipping_tax_rate = $_POST['shipping_tax'];[/B]
            $order->info['shipping_tax'] = $this->calculateOrderShippingTax(true);
            break;
        case 'add_prdct':
            $this->shipping_tax_rate = $tax_rate->fields['shipping_tax_rate'];
            $order->info['shipping_tax'] = $this->eoRoundCurrencyValue(zen_calculate_tax($order->info['shipping_cost'], $this->shipping_tax_rate));
            break;
        default:
            $this->shipping_tax_rate = $tax_rate->fields['shipping_tax_rate'];
            $order->info['shipping_tax'] = $this->calculateOrderShippingTax(false);
            break;
    }

> to sanitize that value on entry.
> 
> See this GitHub issue for follow-on: <https://github.com/lat9/edit_orders/issues/157>
Update provided; see that issue for the change required.

lat9:

Hmm, looks like you've got My Store::Show Split Tax Lines set to false. Let me investigate further.
The work-around for this issue is to update the above setting to true, so that each tax-type's value is recorded as a separate ot_tax order-total.

The underlying cause of the issue is that the order's shipping-tax's "Tax Group" isn't captured as part of the order's processing so that reconstructing the order's taxes when all the taxes are bundled into a single, overall value is 'difficult'.:(

lat9:

The work-around for this issue is to update the above setting to true, so that each tax-type's value is recorded as a separate ot_tax order-total.

The underlying cause of the issue is that the order's shipping-tax's "Tax Group" isn't captured as part of the order's processing so that reconstructing the order's taxes when all the taxes are bundled into a single, overall value is 'difficult'.:(
GitHub issue created for tracking: https://github.com/lat9/edit_orders/issues/158

lat9:

The underlying cause of the issue is that the order's shipping-tax's "Tax Group" isn't captured as part of the order's processing so that reconstructing the order's taxes when all the taxes are bundled into a single, overall value is 'difficult'.:(

I quite agree. Perhaps something involving LIKE (but perhaps excluding default strings like "Tax" or "Sales Tax"?) might work. I can see how this block was created in response to an edge case.

swguy:

I quite agree. Perhaps something involving LIKE (but perhaps excluding default strings like "Tax" or "Sales Tax"?) might work. I can see how this block was created in response to an edge case.
It's actually not an edge case, that shipping-tax handling was created based on various uses where (as in your case) the tax on shipping is different than that associated with the various products in the order.

Finally got around to trying to upgrade my site from 1.3.9h to the latest version, 1.5.7. Love Super Orders and Edit Orders. My Faves for sure. For some reason I cant get edit orders to work and Im thinking its a simple workaround, but I haven't found it yet. I get this error when trying to edit or delete an order

The store's zen_add_tax function must be updated to enable Edit Orders' use.

I see a file with the same name, but opening it did not provide any clues to how to remove it and I have been through every admin tab available with no luck...

My admin log has this message

#1 sizeof() called at [/admen/orders.php:1110]
#2 require(/admen/orders.php) called at [/admen/index.php:11]
--> PHP Warning: sizeof(): Parameter must be an array or an object that implements Countable in /admen/orders.php on line 1110.

Any idea how to squash this message and let edit orders do its work?

johnniejetski2:

Finally got around to trying to upgrade my site from 1.3.9h to the latest version, 1.5.7. Love Super Orders and Edit Orders. My Faves for sure. For some reason I cant get edit orders to work and Im thinking its a simple workaround, but I haven't found it yet. I get this error when trying to edit or delete an order

The store's zen_add_tax function must be updated to enable Edit Orders' use.

I see a file with the same name, but opening it did not provide any clues to how to remove it and I have been through every admin tab available with no luck...

My admin log has this message

#1 sizeof() called at [/admen/orders.php:1110]
#2 require(/admen/orders.php) called at [/admen/index.php:11]
--> PHP Warning: sizeof(): Parameter must be an array or an object that implements Countable in /admen/orders.php on line 1110.

Any idea how to squash this message and let edit orders do its work?
Arggh, that's still not fixed in zc157? Anyway, the Installation :: Changes to zen_add_tax tab in the EO readme identifies the changes needed to the admin's /includes/functions/general.php that are required for EO to do its thing.

That definitely made it better, however when I went to DELETE an order I get this
This page isn’t working
www.MY-SITE. is currently unable to handle this request.
HTTP ERROR 500

johnniejetski2:

That definitely made it better, however when I went to DELETE an order I get this
This page isn’t working
www.MY-SITE. is currently unable to handle this request.
HTTP ERROR 500
... and in your site's /logs sub-directory will be a myDEBUG-adm-{something}.log file containing details as to what that underlying issue is. Remember that since it's an admin log-file, it will contain a reference to your admin directory's name, so you need to xxx-that out prior to posting back.

Lat9 - Can you tell me where the zen_get_countries_name() function is defined at?

I thought i had the module working, but now I am getting an error: PHP Fatal error: Uncaught Error: Call to undefined function zen_get_countries_name() in /home/userdir/public_html/store/admin/includes/functions/extra_functions/edit_orders_functions.php:586

I looked online but I am not seeing the function in any of the ZenCart documentation.

Jeff_Mash:

Lat9 - Can you tell me where the zen_get_countries_name() function is defined at?

I thought i had the module working, but now I am getting an error: PHP Fatal error: Uncaught Error: Call to undefined function zen_get_countries_name() in /home/userdir/public_html/store/admin/includes/functions/extra_functions/edit_orders_functions.php:586

I looked online but I am not seeing the function in any of the ZenCart documentation.

looks like a typo. use:

'name' => zen_get_country_name($country_info->fields['countries_id']),

Yep, that's it.:clap:

carlwhat:

looks like a typo. use:

'name' => zen_get_country_name($country_info->fields['countries_id']),

That was it!  Good catch, and thanks for the help!

Thanks, @dbltoe and @carlwhat, for the support! Changes are staged for the v4.5.2 release of EO.

Jeff_Mash:

That was it! Good catch, and thanks for the help!

lat9:

Thanks, @dbltoe and @carlwhat, for the support! Changes are staged for the v4.5.2 release of EO.

:thumbsup:

I've just submitted v4.5.2 of EO to the Zen Cart moderators for review and will post back here when it's available for download.

 This release contains changes associated with the following GitHub issues:

#151: Use CSS buttons during Edit Orders processing for zc156 and later.
#157: Correct MySQL error when empty shipping-tax value is entered.
#160: Correct integration for product-addition of SBA-managed product.
#163: Use zen_output_string_protected instead of to-be-deprecated zen_db_output.
#165: Correct function name (zen_get_country_name) to prevent PHP fatal error.

Thanks to @proseLA and @mc12345678 for their contributions!

lat9:

I've just submitted v4.5.2 of EO to the Zen Cart moderators for review and will post back here when it's available for download.

 This release contains changes associated with the following GitHub issues:

#151: Use CSS buttons during Edit Orders processing for zc156 and later.
#157: Correct MySQL error when empty shipping-tax value is entered.
#160: Correct integration for product-addition of SBA-managed product.
#163: Use zen_output_string_protected instead of to-be-deprecated zen_db_output.
#165: Correct function name (zen_get_country_name) to prevent PHP fatal error.

Thanks to @proseLA and @mc12345678 for their contributions!
Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1513

i get this error when i try to add the admin menu
In the attachment you will see what i added and the error i got

thank you
noppie