Edit Orders v4.0 Support Thread

@noppie - You should not be having to do anything other than loading the files and logging into the admin. The rest should be done automatically.

You don't mention the version of ZC you are using but, with 1.5.7 AND a pre-existing version of EO, we have found that running the uninstall_eo.sql file located in docs/edit_orders/uninstall and then logging back into admin (refreshing the home page) will properly load the mod.

SO....If you had EO before, loaded the new files, and the mod did not "do it's thing"; try running the uninstall_eo.sql file and clicking admin home when you're through.

i am on 156f because that works with the multil-site. and that is what i thought,
thank you for answering but now i dont know what to do.

Well, here's how you have US confused.

The domain in your sig tells us it doesn't exist although it is registered. It was either just registered or just renewed. You're registered with wild west but there's no way to purchase a domain from them. They are a subsidiary of GoneDaddy.

And, there is no Zen Cart version 156f. 1.5.5 went to f but, 1.5.6 only went to c. 1.5.7 is not quite to a.

Someone has a redirect on your site sending everything to herasonlinemarket.com/shop/index.php

Perhaps you can take the time to open a separate thread as there is far more going on here than Edit Orders. In that new thread, PLEASE answer ALL the Posting Tips questions that come up when you start the new thread.

dbltoe:

Well, here's how you have US confused.

The domain in your sig tells us it doesn't exist although it is registered. It was either just registered or just renewed. You're registered with wild west but there's no way to purchase a domain from them. They are a subsidiary of GoneDaddy.

And, there is no Zen Cart version 156f. 1.5.5 went to f but, 1.5.6 only went to c. 1.5.7 is not quite to a.

Someone has a redirect on your site sending everything to herasonlinemarket.com/shop/index.php

Perhaps you can take the time to open a separate thread as there is far more going on here than Edit Orders. In that new thread, PLEASE answer ALL the Posting Tips questions that come up when you start the new thread.

it is because of the multi site mode that is acting up.
and i think i got that working now.

so i still get the error above..
thank you
noppie

dbltoe:

Perhaps you can take the time to open a separate thread as there is far more going on here than Edit Orders. In that new thread, PLEASE answer ALL the Posting Tips questions that come up when you start the new thread.Or don't. Your choice.

as i said it is working now.. it was not working because of a mis configuration of the multi site. the admin no problems
but i dont really need this that much.. i will try another day.
noppie

When I edit an order it is basing the product tax on a rounded unit value. Example:

My customer changed their quantity of cheques to 1000 forms. The unit cost for the new quantity is $0.176 which I input in the "Unit price" box. When I hit update, it changes the Unit Price to $0.80 (not a big deal really for display), the "Total" changes to the correct price of $176.00. Down in the tax section, however it is calculating the tax on the rounded value of $0.80, not the subtotal value of $176.00. (see attached EO1.jpg).

Is there an easy fix to have it calculate the tax off the subtotal?

Colleen, thanks for the report. I'll see what's up in the morning.

I've just submitted v4.5.3 of Edit Orders.

 This release contains changes associated with the following GitHub issues:

#158: Document the configuration required for stores with separate tax-rates on shipping.
#167: Early rounding causes products' pricing errors when prices have more significant digits than the currency supports.
#169: Use 'floatval' instead of a float-cast to reduce penny-off calculations.
#170: Correct PHP warning when shipping is removed from an order.

Now available for download: https://www.zen-cart.com/downloads.php?do=file&id=1513

I have a rough solution to the edit buttons becoming blue circles and duplication of the edit buttons.

In admin | includes | classes | observers |EDitOrdersAdminObserver.php on line 83 (approx) I changed

p4 .= $this->createEditOrdersLink($p2['orders_id'], zen_image(DIR_WS_IMAGES . EO_BUTTON_ICON_DETAILS, EO_ICON_DETAILS), EO_ZC156_FA_ICON, false); to
p4 .= $this->createEditOrdersLink($p2['orders_id'], zen_image(DIR_WS_IMAGES . EO_BUTTON_ICON_DETAILS, EO_ICON_DETAILS), ' ', false);
The original edit button (white e on green circular background) remains with the blue triangle on the right.

Environment Test: Zen Cart 157; Apache 2.4.46; PHP 7.3.21; MySQL 5.7.31; Linux 4.15.0

I've got an update posted on the EO GitHub repository that corrects that wonky display: https://github.com/lat9/edit_orders/commit/1f00f4c916eb89b507007e40159276987f05c60d

plugin for a plugin!

if you have additional fields added to your orders_products table, and have been frustrated by those fields not being there when adjusting quantities, be frustrated no longer!

plugin:
https://www.zen-cart.com/downloads.php?do=file&id=2292

its own support thread:
https://www.zen-cart.com/showthread.php?227315-support-thread-edit-orders-gt-detail-record-copy

best.

lat9:

I've got an update posted on the EO GitHub repository that corrects that wonky display: https://github.com/lat9/edit_orders/commit/1f00f4c916eb89b507007e40159276987f05c60d

Nice... I just added a color style to the stack overlay which worked for the round circle.. I like the square, but now I have to fix the old edit icon in orders.php to match.. I Switched back.. That didn't look so well, so went back to the round buttons by adding a white font color to the stack overlay and matching the size of the edit icon.

What's going to happen if admin ever jumps to version 6 of Font Awesome! My catalog side at 5 soon to be 6 and admin at 4, I have to keep 2 sets of reference tables handy... With everyone stuck at home, seems versions of everything is running wild right now... Thanks for your work on this mod.

Hello. I use a screen reader with Zencart and Edit Orders. Because of the current table layout, the address items are reading across for me instead of down - in other words, all of the name fields, followed by all of the address fields, etc.

There's a couple of ways to fix this. The prefered method would be to start using CSS for the layout of the page instead of a lot of nested tables. I realize this may be a larger task however.

The short-term fix would likely be putting each of the address types in its own single-column, vertical nested table. This should allow for proper display order while not changing the visuals.

I'm happy to work on this and submit a PR, but wanted to seek some guidance first. There are other accessibility things that could be done as well, including adding labels to the form fields.

Thanks for your work on the add-on. I appreciate the modern add-ons that use the override system and are much easier to maintain.

jsquared:

Hello. I use a screen reader with Zencart and Edit Orders. Because of the current table layout, the address items are reading across for me instead of down - in other words, all of the name fields, followed by all of the address fields, etc.

There's a couple of ways to fix this. The prefered method would be to start using CSS for the layout of the page instead of a lot of nested tables. I realize this may be a larger task however.

The short-term fix would likely be putting each of the address types in its own single-column, vertical nested table. This should allow for proper display order while not changing the visuals.

I'm happy to work on this and submit a PR, but wanted to seek some guidance first. There are other accessibility things that could be done as well, including adding labels to the form fields.

Thanks for your work on the add-on. I appreciate the modern add-ons that use the override system and are much easier to maintain.
I understand the issue. That 'funky' address layout has been with Edit Orders since I 'inherited' the plugin.

Unfortunately, there's more to the change than simply re-formatting those address areas. There are other plugins (e.g. VAT for EU Countries) that make use of EO-issued notifications to add their extra fields to those address blocks.

I'll create an issue in EO's GitHub repository so that this request isn't lost; it'll be considered in a future EO version.

Issue created: https://github.com/lat9/edit_orders/issues/175

Ah, I see the hooks that are being used for other plugins so that indeed will take more work. I submitted a very small PR to add a role of table to the address table so at least screen readers will recognize the table as a data table and not presentation and let users move around it more easily.

lat9:

Arggh, that's still not fixed in zc157? Anyway, the Installation :: Changes to zen_add_tax tab in the EO readme identifies the changes needed to the admin's /includes/functions/general.php that are required for EO to do its thing.

I don't know if its because I'm using a mac, or if it was left out of the 1.5.7 release... but I cannot locate any instructions on what needs to be modified in the file to activate the edit orders mod with the error: The store's zen_add_tax function must be updated to enable Edit Orders' use.

What needs modified below?

/** * Add tax to a products price
*/
function zen_add_tax($price, $tax, $force = false) {
global $currencies;

if (DISPLAY_PRICE_WITH_TAX_ADMIN == 'true' || $force) {
  return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']) + zen_calculate_tax($price, $tax);
} else {
  return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
}

}

/**

Carbonless:

I don't know if its because I'm using a mac, or if it was left out of the 1.5.7 release... but I cannot locate any instructions on what needs to be modified in the file to activate the edit orders mod with the error: The store's zen_add_tax function must be updated to enable Edit Orders' use.

What needs modified below?

/** * Add tax to a products price
*/
function zen_add_tax($price, $tax, $force = false) {
global $currencies;

if (DISPLAY_PRICE_WITH_TAX_ADMIN == 'true' || $force) {
  return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']) + zen_calculate_tax($price, $tax);
} else {
  return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
}

}

/**
In EO's readme, click the ***Installation ***tab, then the Changes to zen_add_tax tab.

I tried installing this mod on my new 1.5.7 install on Friday evening (have it on my old 1.3.7h working fine for years) with the Westnminster-new template and it didn't like it at all. Followed all the steps in order, did the tax changes, etc. It didn't activate in the admin area, and then when I went to the storefront, no products were showing. Went through all the files again to make sure I hadn't missed one... nope, all there, So i uninstalled it and will hope that one day it actually becomes a built in feature as it is a very handy tool to have when clients want to add to their order.

lat9:

In EO's readme, click the ***Installation ***tab, then the Changes to zen_add_tax tab.

From the downloads the zip did not contain a readme file... these instructions are what i'm looking for..