[Done 155b] Shipping tax not added in order confirmation - possible bug??

Ajeh:

And you have each Zone for Australia added individually in the Zone Details, correct?

No Ajeh, never added each zone (state) individually for Australia in the Zone Details - never have since ZC 1.3.7 as the same tax rules apply in every state of Oz. What puzzles me is that it has worked without a glitch ever since, the issue only appeared since the upgrade from 1.5.4 to 1.5.5a .....

In the Zone Details, if you Edit it what do you see:

Edit Sub Zone
|

 Please make any necessary changes | 

 Country:

|

|

Zone:
|

Ajeh:

In the Zone Details, if you Edit it what do you see:

Does that help?

I would like you to go to Zone Definitions where the title on the page reads:

Zone Definitions - Taxes, Payment and Shipping

and click on DETAILS ... then click on it to see what is in the DETAILS of the Zone and edit that ...

Either it says Country Australia and the sub zone reads Please Select or you have each of the 8 sub zones in it ...

Hi

I tried this a clean install of v155 and could not see any problems.

Here is what I did.

Clean Install
Admin set DISPLAY_PRICE_WITH_TAX = true
Created Tax Class called 'Shipping Tax'
Created tax rate for 'Shipping Tax' for 'Florida' Zone @10%
Assigned 'Shipping Tax' to Flat Rate shipping 'Tax Class'

Created an order, and at all points in checkout correct values were shown. In admin correct values were shown in orders/invoices etc

So I am stumped as to why you have problems

Anyway lets try to work backwards to see what the settings should be

Firstly, I assume you have set a Tax Class against your shipping module
You must also have previously created a 'Shipping Tax Class' in admin/tax_classes.php
Then a Shipping Tax Rate in admin/tax_rates.php using the 'Shipping Tax Class' and assigning it to a Zone
Is the Zone there the same as say the Zone you use for product taxes, or did you create a new zone for the shipping tax

Ajeh:

I would like you to go to Zone Definitions where the title on the page reads:

and click on DETAILS ... then click on it to see what is in the DETAILS of the Zone and edit that ...

Either it says Country Australia and the sub zone reads Please Select or you have each of the 8 sub zones in it ...

Thanks Ajeh, it says 'Country Australia and the sub zone reads Please Select' .... as per earlier posts, no changes made to these settings since 2007.

wilt:

Hi

I tried this a clean install of v155 and could not see any problems.

Here is what I did.

Clean Install
Admin set DISPLAY_PRICE_WITH_TAX = true
Created Tax Class called 'Shipping Tax'
Created tax rate for 'Shipping Tax' for 'Florida' Zone @10%
Assigned 'Shipping Tax' to Flat Rate shipping 'Tax Class'

Created an order, and at all points in checkout correct values were shown. In admin correct values were shown in orders/invoices etc

So I am stumped as to why you have problems

Anyway lets try to work backwards to see what the settings should be

Firstly, I assume you have set a Tax Class against your shipping module
You must also have previously created a 'Shipping Tax Class' in admin/tax_classes.php
Then a Shipping Tax Rate in admin/tax_rates.php using the 'Shipping Tax Class' and assigning it to a Zone
Is the Zone there the same as say the Zone you use for product taxes, or did you create a new zone for the shipping tax

Did you also set the store side tax to 'true'?

Okay, this I think is the issue ...

Where it says Please Select, do you see the 8 sub zones in the drop down?

If so, can you add each of the 8 sub zones?

Does it work?

Ajeh:

Okay, this I think is the issue ...

Where it says Please Select, do you see the 8 sub zones in the drop down?

If so, can you add each of the 8 sub zones?

Does it work?

Will do that in the morning - almost 2am here now, eyes are getting a bit heavy - will report back when done. Thank you so much to all so far - talk tomorrow.

You realize we will be on pins and needles until you test that right? :lookaroun

Fresh eyes and brain...... thanks for your patience.

wilt:

Firstly, I assume you have set a Tax Class against your shipping module
Yes, same since Nov 2007

wilt:

You must also have previously created a 'Shipping Tax Class' in admin/tax_classes.php
Yes, no change since Nov 2007

wilt:

Then a Shipping Tax Rate in admin/tax_rates.php using the 'Shipping Tax Class' and assigning it to a Zone
Is the Zone there the same as say the Zone you use for product taxes, or did you create a new zone for the shipping tax
Yes, there is only one single Tax Class.

Everything was working perfectly until the last upgrade. Shipping charge always showed with 10% GST included.

Ajeh:

Okay, this I think is the issue ...

Where it says Please Select, do you see the 8 sub zones in the drop down?

If so, can you add each of the 8 sub zones?

Does it work?

Now added all 8 sub zones (previously the setting was 'All Zones' for Australia), did a test order and the shipping charge still shows without GST. Didn't think it would make any difference by adding all 8 sub zones as that is the same as have the setting 'All Zones'.

I know this is a recording, but the shipping charge always showed perfectly until the last upgrade from 1.5.4 to 1.5.5a

The interesting bit is that the shipping charge shows correctly (incl GST) during the entire checkout process (customer side) but is wrong in admin, order and invoice.

Does it show right on the checkout_success? (where it says Thank You to the customer and shows the details of the order)

Ajeh:

Does it show right on the checkout_success? (where it says Thank You to the customer and shows the details of the order)

Thanks Ajeh, on my checkout_success page it shows just

**Your Order Number is:** 11013054	

Thank You for Your Order Frank !
Your transaction has been completed, and a receipt for your purchase has been emailed to you.

Using Responsive Sheffield Blue template (adapted all changes necessary for 1.5.5a , obtained a working file set from rbarbour).

Now that triggered a light bulb: I did another test order using the new Responsive Classic template. And there it shows shipping with no tax included.

So the fault must be happening when confirming the order....

Is this a test upgrade to v155a?

If this is a Test or working site, as in not Live, can you switch to the Classic Template and try a checkout ... Does the checkout_success have the right numbers all the way through?

Is this a site that we can perhaps peek at?

Ajeh:

Is this a test upgrade to v155a?

If this is a Test or working site, as in not Live, can you switch to the Classic Template and try a checkout ... Does the checkout_success have the right numbers all the way through?

Is this a site that we can perhaps peek at?

I am doing all the testing on a local clone of the live site (frnt dot com dot au) - it is the live site where this became evident with a customer doing an order below the free shipping threshold of $150 (all other orders since upgrading were over $150 - hence no shipping charged and therefore no shipping tax applicable).

Just did another test (locally) using the Contemporary Classic Green and the same issue persists: all shows fine up and including the order_confirmation page but shipping shows excluding tax on the checkout_success page and in admin.

Did another comparison (ZC install files vs site files) with my trusted Beyond Compare

includes/classes/order_total.php
includes/classes/order.php
includes/functions/functions_taxes.php

and a few other functions and various includes/modules/pages/....../header_php.php files but they all look identical!

Got it working again.

Created another fresh clone for this module (zones4), tested it locally and it works as expected - all good.

All I can put this down to is a corrupted FTP transfer when I first uploaded all the new/modified files to the server after the upgrade was completed locally.

After that my usual practice is to zip up my local upgrade file set and then delete all files locally. Then I usually download a complete live site mirror so I have exactly the same file system locally as I have it on the live store, so the 2 sets were identical but for the 2 configure files.

After creating a new clone and testing it locally to satisfaction, the newly created clone (zones4) now runs ok on the live site.

A rare incident, I know, but sometimes you-know-what :censored: happens! Just cost me a bit more hair-loss.........

Thanks again to all for taking the time and assistance.

Cheers / Frank

frank18:

Got it working again.

Created another fresh clone for this module (zones4), tested it locally and it works as expected - all good.

All I can put this down to is a corrupted FTP transfer when I first uploaded all the new/modified files to the server after the upgrade was completed locally.

After that my usual practice is to zip up my local upgrade file set and then delete all files locally. Then I usually download a complete live site mirror so I have exactly the same file system locally as I have it on the live store, so the 2 sets were identical but for the 2 configure files.

After creating a new clone and testing it locally to satisfaction, the newly created clone (zones4) now runs ok on the live site.

A rare incident, I know, but sometimes you-know-what :censored: happens! Just cost me a bit more hair-loss.........

Thanks again to all for taking the time and assistance.

Cheers / Frank

In creating the clone... did you have to "install" it to the system? Ie. Any sql that had to be performed?

I don't/didn't see any such discussion (I thought) before.

mc12345678:

In creating the clone... did you have to "install" it to the system? Ie. Any sql that had to be performed?

I don't/didn't see any such discussion (I thought) before.

Absolutely! That is common practice when uploading a new clone.

frank18:

Absolutely! That is common practice when uploading a new clone.

And with the "previous" clone "transferred" to this file system but already populated in the database (since 2007 :P)? Was it "removed" either prior to the database upgrade or upon the database upgrade and subsequently reinstalled?