[Done 155b] Shipping tax not added in order confirmation - possible bug??

I just upgraded to 1.5.5a from 1.5.4 and I have the exact same issues as report here. My order during checkout process is showing everything right. Shipping tax is included. But once the customer purchases using PayPal and then returned to the website the Shipping taxes are now not being shown. Plus the email confirmation also doesn't include the shipping taxes included. Therefore got customers calling as Paypal has charged them more then what the confirmation email showed. Of course Paypal is correct as everything was right during checkout, but tax on shipping missing after.

If anyone who also had this issue, what exactly did you do to fix the issue. Is the issues with the zones, shipping modules?

What shipping module are you using?

Do you have display prices with tax in Catalog and the Admin turned on or off?

Also in the Zone Definitions for taxes, what Country is set?

Do you see Please Select or All Zones or do you have individual Zones added?

mmcculli:

I just upgraded to 1.5.5a from 1.5.4 and I have the exact same issues as report here. My order during checkout process is showing everything right. Shipping tax is included. But once the customer purchases using PayPal and then returned to the website the Shipping taxes are now not being shown. Plus the email confirmation also doesn't include the shipping taxes included. Therefore got customers calling as Paypal has charged them more then what the confirmation email showed. Of course Paypal is correct as everything was right during checkout, but tax on shipping missing after.

If anyone who also had this issue, what exactly did you do to fix the issue. Is the issues with the zones, shipping modules?

And in addition to Ajeh's questions, did you uninstall then re-install your shipping modules when upgrading?

From the upgrade instructions (found in the /docs folder):

NOTICE: Re: Payment AND Shipping Modules

You will need to re-install all your active payment and shipping modules as part of your upgrade:

• BEFORE UPGRADING, Take note of the login IDs, transaction keys, email addresses and other settings already configured in EACH of your Payment AND Shipping modules (You'll need this info so you can re-enter it after Installing the modules again).

• Remove each module by clicking the "Remove" button for each one.

• AFTER UPGRADING, Install each module (that you're using) in Admin->Modules->Payment and Admin->Modules->Shipping in order to take advantage of the bugfixes and feature improvements in each module. (you do NOT need to do this with modules you're NOT using. If you're no longer using a certain module anymore and it doesn't have a red dot next to it, click the "Remove" button to save on processing performance.)

• Re-enter all your configuration settings for each module as you go along. BE SURE TO TEST each one before you take your store live again, to make sure you've got all your settings entered correctly.

I am using Table Rate Shipping Modules. I didn't uninstall and reinstall any of the modules (Shipping or Payment). I didn't see that instructions, I figured going for 1.5.4 to 1.5.5a would be a small upgrade.

I am in Canada. I have the Zone Definitions groups by Provinces and each province in Canada has different tax rates, plus the shipping cost(Table Rate) would be also different by province. So have I 4 clones(copy) for the Table.php.

I have removed and reinstalled the Table Rate Shipping Module. Still no luck. The part I find interesting is it shows the taxes and total right during the checkout process. It is not until you complete the order does it show the taxes/total wrong. It forwards the right amount to the payment module (PayPal). But once complete and you are on the "main_page=checkout_success" page doe it show the taxes wrong. Plus the email sent out is also wrong. How does it do everything right until the end, plus there was not to many changes to ZenCart 1.5.5a from 1.5.4 I thought looking at the list.

Just as a test, if you edit one of the Table rates and leave the setting for the Taxes but remove the Zone setting, does it work?

Then if you edit it again and put back the Zone setting, does it break again?

Yes it works if I removed the Zone Setting. When I add the zone setting back in it breaks again.

Still not sure of the fix yet but this helps to narrow it down ...

Is there any screenshot I can sent for you can see how I have it setup. Been running the same setup since version 1.3.8 without issues.

It is a little confusing as each province has difference tax rates. See image below were I show the breakdown. I separated shipping from products.

Next in the Zone Definitions area. I have grouped the different zones(provinces) and their taxes. But for Shipping zone definitions I don't have taxes linked in, just the zones. (they are yellow status)

Then if you look at the Table Rate I link in the Tax Class and Shipping Zones.

Maybe there is a better way now days to configure this. I setup on configuration based on an article I found back in 2009. Worked fine until I upgraded to 1.5.5a.

Not sure how it all works but I just realized as I am using 4 Table Rate shipping modules I have four clones of includes/modules/shipping/table.php But my table2.php, table3.php and table4.php are not version 1.5.5. Old versions.

Of course right now when I am testing I am just using the first one table.php. Not the other three.

No, I can reproduce the problem ... now the goal is we are looking how to correct the problem ... :lookaroun

I was having issues with reproducing the problem as I did not have the Zone set on the shipping module and just had set the Tax Class ...

Just checking back in to see if you have been able to recreate the issue(bug) on your side so you can hopefully soon patch the bug.

Have recreated it and it happens when a Zone is set on the shipping module ... without the Zone set it works ...

We are still working on a solution for this ...

Ajeh:

Have recreated it and it happens when a Zone is set on the shipping module ... without the Zone set it works ...

We are still working on a solution for this ...
So it wasn't just a botched up FTP upload on my end after all :huh:??

My guess is you had a Zone set then did not when you reinstalled ...

It is possible that there was another issue, but so far I am not finding any other trigger for this. I thought your reinstall was the fix also, as the same thing happened for me. But then I realized that I had the Zone set when it was broken and on the new install I did not have the Zone set.

So it was just a dilussion on my testing, making me think a new install fixed it, until I really tested it a lot further for the real issue ... :lookaroun

Ajeh:

My guess is you had a Zone set then did not when you reinstalled ...

It is possible that there was another issue, but so far I am not finding any other trigger for this. I thought your reinstall was the fix also, as the same thing happened for me. But then I realized that I had the Zone set when it was broken and on the new install I did not have the Zone set.

So it was just a dilussion on my testing, making me think a new install fixed it, until I really tested it a lot further for the real issue ... :lookaroun

Thanks for the update Ajeh. If I hate any error, bug, fault, whatever then it is one of an intermittent, inconsistent nature, just like one in the electrics in a car......

Is there anything I can do to help? I do have the website in a sandbox so can test things out if you like.

As an EXPERIMENT (no guarantees here with this idea), you could try the following...

/includes/modules/checkout_process.php
Around line 51 you'll see this section of code:```
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

Try moving the shipping-module part down a few lines, like this:```
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

$shipping_modules = new shipping($_SESSION['shipping']);

Note: ZC v155b includes this fix:
https://github.com/zencart/zencart/pull/1034

I have moved the line down and it seem to have worked. Taxes on Shipping are now showing up as they did before I upgraded to 1.5.5a. So this very small change looks to have fixed the issue.

So what are the side-effects of this change?