[Done 155b] Shipping tax not added in order confirmation - possible bug??

Note! DrByte has added the fix for v1.5.5b:

https://www.zen-cart.com/showthread.php?220280-Done-155b-Shipping-tax-not-added-in-order-confirmation-possible-bug&p=1312461#post1312461

-> https://github.com/zencart/zencart/pull/1034

DrByte:

As an EXPERIMENT (no guarantees here with this idea), you could try the following...

/includes/modules/checkout_process.php
Around line 51 you'll see this section of code:```
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

> 
> Try moving the shipping-module part down a few lines, like this:```
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

$shipping_modules = new shipping($_SESSION['shipping']);

Note: ZC v155b includes this fix:
https://github.com/zencart/zencart/pull/1034

Having the same problem in 1.5.5e

I noticed the code had been moved around like this:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

So I am just trying to move it in the same order as your post, like this to see if it fixes the issue.

So its like this:

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
$shipping_modules = new shipping($_SESSION['shipping']);

@Nick1973; the change required that the order-class object be created prior to the shipping-class object ... so both the post that you reference and the code that's in the ZC 1.5.5e contain the same processing.

Make sure, too, that you don't have a template-override version of the checkout_process.php handling (i.e. /includes/modules/YOUR_TEMPLATE/checkout_process.php) that doesn't include the update.

lat9:

@Nick1973; the change required that the order-class object be created prior to the shipping-class object ... so both the post that you reference and the code that's in the ZC 1.5.5e contain the same processing.

Make sure, too, that you don't have a template-override version of the checkout_process.php handling (i.e. /includes/modules/YOUR_TEMPLATE/checkout_process.php) that doesn't include the update.

No definitely no override file.

VAT is set up using the core Zen Cart System. There aren't any plugins calculating VAT other table rate shipping.

Shipping is set up using Table Rate Clones, similar to what people have talked about in this thread.

Please see the screenshots in the zip file in this link:

https://www.ventureonlineuk.co.uk/screenshots.zip

These will help you understand how shipping has been set up in the cart.

Nick1973:

So I am just trying to move it in the same order as your post, like this to see if it fixes the issue.

So its like this:

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
$shipping_modules = new shipping($_SESSION['shipping']);

So has this actually fixed your issue??

frank18:

So has this actually fixed your issue??

Not sure yet, I am waiting for an order at the moment. I will try and test it shortly though. I realised after that my SSL was out of date on my site so you may have got a security error.

Nick1973:

Not sure yet, I am waiting for an order at the moment. I will try and test it shortly though. I realised after that my SSL was out of date on my site so you may have got a security error.

SSL now fixed so you should be able to get to the attachments.

Nick1973:

SSL now fixed so you should be able to get to the attachments.

Ok even after making the change as stated by Dr Byte and switching the table rate modules off then back on, VAT is still not being charged on delivery.

Nick1973:

Ok even after making the change as stated by Dr Byte and switching the table rate modules off then back on, VAT is still not being charged on delivery.

In this thread that was started, the report was that VAT was not being calculated in the admin. Then here it was reported that operation of the store was the same as previously reported in this thread. So far, no data has been shown about what is actually happening.
Ie.
What does the order confirmation show?
What is the result in the various locations within the admin where the issue seems to appear?
During the checkout process where does the "calculation" appear incorrectly?
What payment module(s) are involved?
How has the store been otherwise modified or amplified (what files have been added or attempted to be renamed)?

> mc12345678:

In this thread that was started, the report was that VAT was not being calculated in the admin. Then here it was reported that operation of the store was the same as previously reported in this thread. So far, no data has been shown about what is actually happening.
Ie.
What does the order confirmation show?
What is the result in the various locations within the admin where the issue seems to appear?
During the checkout process where does the "calculation" appear incorrectly?
What payment module(s) are involved?
How has the store been otherwise modified or amplified (what files have been added or attempted to be renamed)?

Ok if you look further up I have supplied screenshots you can download of how shipping, countries, zones, VAT etc is set up.

You can get them here https://www.ventureonlineuk.co.uk/screenshots.zip

I've attached a further screenshot of the admin after the order, get your calculator out and you will see its not adding VAT to the shipping cost.

What does the order confirmation show? The order confirmation email shows the same as what appears in the admin.

What is the result in the various locations within the admin where the issue seems to appear? There's only one location and that is Customers > Orders

During the checkout process where does the "calculation" appear incorrectly? No it doesn't appear incorrectly, and the customer pays the 'cost of the product + VAT' and 'cost of shipping + VAT' NOT 'cost of the product + VAT' and 'cost of shipping - no VAT'

What payment module(s) are involved? - Worldpay V.3.0

How has the store been otherwise modified or amplified (what files have been added or attempted to be renamed)? - none that would affect the checkout process, and before you jump on this, I cannot give you a run down of every single file that has been changed, but I do know none of them would affect the checkout process since nothing has been changed there.

Disregard this thread https://www.zen-cart.com/showthread.php?222350-VAT-Not-calculating-in-admin

I'd opened it before discovering the thread we are on now, which appears to be people experiencing similar issues.

bottyz:

Hi Rued,

Sorry for the late reply (I was on holiday in Turkey), and thanks for your help. I found the issue and it wasn't anything to do with the invoice mod. It actually turned out to be a problem with the wp_checkout_proccess.php file with the worldpay module.

The above file is mostly a duplicate of the first part of the checkout_process.php file, which Dr Byte has suggested needs the shipping / order lines swapping round. I've swapped these round in the worldpay file and all seems well.

Thanks again.

Nick1973:

Ok if you look further up I have supplied screenshots you can download of how shipping, countries, zones, VAT etc is set up.

You can get them here https://www.ventureonlineuk.co.uk/screenshots.zip

I've attached a further screenshot of the admin after the order, get your calculator out and you will see its not adding VAT to the shipping cost.

What does the order confirmation show? The order confirmation email shows the same as what appears in the admin.

What is the result in the various locations within the admin where the issue seems to appear? There's only one location and that is Customers > Orders

During the checkout process where does the "calculation" appear incorrectly? No it doesn't appear incorrectly, and the customer pays the 'cost of the product + VAT' and 'cost of shipping + VAT' NOT 'cost of the product + VAT' and 'cost of shipping - no VAT'

What payment module(s) are involved? - Worldpay V.3.0

How has the store been otherwise modified or amplified (what files have been added or attempted to be renamed)? - none that would affect the checkout process, and before you jump on this, I cannot give you a run down of every single file that has been changed, but I do know none of them would affect the checkout process since nothing has been changed there.

Last edited by Nick1973; 31 May 2017 at 07:36 AM.

So yes, had reviewed all of the images which generally showed "everything" but certainly made it difficult to identify if there was a difference that caused an issue... I.e. a sample of one "set" would have been sufficient if all testing indicated that all of the others experienced the same problem.

Now that said and in line with other communication in this thread, note the above quoted post. It specifically relates to Worldpay and does not involve the checkout_X files that supposedly have been changed away from the ZC 1.5.5 version of the sequence.

So what does your wp_checkout_process.php file look like? (Found in includes/modules/wp_checkout_process.php)

My guess is that it looks like this currently beginning at/around line 24:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

Instead of the suggested method (Moving the red text to below the new order):

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

Further, to confirm that this is in fact a result of the payment module, if you were temporarily enable say check/money order and perform a checkout using that payment method and confirm that the results are as expected/desired it would identify that the payment method is at play (which bottyz already has confirmed).

Nick1973:

Disregard this thread https://www.zen-cart.com/showthread.php?222350-VAT-Not-calculating-in-admin

I'd opened it before discovering the thread we are on now, which appears to be people experiencing similar issues.

With the additional information validating that the issue experienced actually does match the issue described makes that quite true. As such you already provided a link from that thread to this one so if someone stumbles across it in a similar search they should come to here and hopefully find their answer.

mc12345678:

So yes, had reviewed all of the images which generally showed "everything" but certainly made it difficult to identify if there was a difference that caused an issue... I.e. a sample of one "set" would have been sufficient if all testing indicated that all of the others experienced the same problem.

Now that said and in line with other communication in this thread, note the above quoted post. It specifically relates to Worldpay and does not involve the checkout_X files that supposedly have been changed away from the ZC 1.5.5 version of the sequence.

So what does your wp_checkout_process.php file look like? (Found in includes/modules/wp_checkout_process.php)

My guess is that it looks like this currently beginning at/around line 24:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

> 
> Instead of the suggested method (Moving the red text to below the new order):
> ```
// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

Further, to confirm that this is in fact a result of the payment module, if you were temporarily enable say check/money order and perform a checkout using that payment method and confirm that the results are as expected/desired it would identify that the payment method is at play (which bottyz already has confirmed).

I'd already moved it, like this, and missed the bit about Worldpay so my apologies if I missed that in reading.

I have now changed the below from this:
/ load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
$payment_modules = new payment($_SESSION['payment']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

To this:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

Nick1973:

I'd already moved it, like this, and missed the bit about Worldpay so my apologies if I missed that in reading.

I have now changed the below from this:
/ load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
$payment_modules = new payment($_SESSION['payment']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

To this:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

In what file did you make the above changes? (basically commented out the use of the session payment information and forced the worldpay module as the payment method)

mc12345678:

So yes, had reviewed all of the images which generally showed "everything" but certainly made it difficult to identify if there was a difference that caused an issue... I.e. a sample of one "set" would have been sufficient if all testing indicated that all of the others experienced the same problem.

Now that said and in line with other communication in this thread, note the above quoted post. It specifically relates to Worldpay and does not involve the checkout_X files that supposedly have been changed away from the ZC 1.5.5 version of the sequence.

So what does your wp_checkout_process.php file look like? (Found in includes/modules/wp_checkout_process.php)

My guess is that it looks like this currently beginning at/around line 24:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

> 
> Instead of the suggested method (Moving the red text to below the new order):
> ```
// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

Further, to confirm that this is in fact a result of the payment module, if you were temporarily enable say check/money order and perform a checkout using that payment method and confirm that the results are as expected/desired it would identify that the payment method is at play (which bottyz already has confirmed).

Further review indicates that possibly need to swap some of the other lines as well to at least align with the ZC 1.5.5 version of this area:

from includes/modules/pages/checkout_confirmation/header_php.php:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order_total.php');
$order_total_modules = new order_total;
$order_total_modules->collect_posts();
$order_total_modules->pre_confirmation_check();
// load the selected payment module
require(DIR_WS_CLASSES . 'payment.php');

Notice the sequence: order, shipping, payment... This is still different as compared to a fresh install of WorldPay V3.0 as downloaded from the website which has it as: payment, shipping, order.

So actually looks like includes/modules/wp_checkout_process.php in this area should be changed from:

// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

possibly to:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

And maybe even include order totals type code moving to after the shipping code and before the payment code.

mc12345678:

Further review indicates that possibly need to swap some of the other lines as well to at least align with the ZC 1.5.5 version of this area:

from includes/modules/pages/checkout_confirmation/header_php.php:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order_total.php');
$order_total_modules = new order_total;
$order_total_modules->collect_posts();
$order_total_modules->pre_confirmation_check();
// load the selected payment module
require(DIR_WS_CLASSES . 'payment.php');

> 
> Notice the sequence: order, shipping, payment...  This is still different as compared to a fresh install of WorldPay V3.0 as downloaded from the website which has it as: payment, shipping, order.
> 
> So actually looks like includes/modules/wp_checkout_process.php in this area should be changed from:
> ```
// load selected payment module
require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');
// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

possibly to:

require(DIR_WS_CLASSES . 'order.php');
$order = new order;

// load the selected shipping module
require(DIR_WS_CLASSES . 'shipping.php');
$shipping_modules = new shipping($_SESSION['shipping']);

require(DIR_WS_CLASSES . 'payment.php');
// $payment_modules = new payment($_SESSION['payment']);
$payment_modules = new payment('worldpay');

> 
> And maybe even include order totals type code moving to after the shipping code and before the payment code.

Well after changing that code, an order came through and the callback failed.

Nick1973:

Well after changing that code, an order came through and the callback failed.

Although I will say I hadn't changed your extra bits.

Nick1973:

Well after changing that code, an order came through and the callback failed.

That seems to be a running issue that is discussed in the WorldPay Version 3.0 thread with some included discussion/correction by niccol.

Long and short of it, although there was an equivalent system problem as was reported related to ZC core code, this issue is related to a plugin and its integration with ZC and not specifically ZC. It is unfortunate that countrycharm is no longer available to support further upgrade, but well, that's how life goes.

Recommendation would be to carry the discussion and problem resolution(s) further in that module's thread so that others using WorldPay may further help or also gain from the corrections.