Zen Follower
- Join Date:
- Apr 2019
- Posts:
- 362
- Plugin Contributions:
- 0
Views: 629,253
Zen Follower
Administrator
The "thing" is that the billing address is always required, but the shipping address (think 'virtual products') isn't. That's why the billing address is displayed first.
Totally Zenned
There still appears to be a problem for me with the Square Web Pay Module.
I get the SQ-MSCONF error with Square after installing OPC, but if I edit jquery.checkout_one.js as suggested by carlwhat here https://www.zen-cart.com/showthread.php?228750-Square-WebPay-support-thread&p=1387913#post1387913
It works.
One thing I have noticed is that once the 'Confirm Order' button is clicked, it hangs on the greyed out screen. Which can be confusing to customers. If it needs to do that while processing, maybe it should have a notice pop up something like 'Please Wait, Order Processing. Do not close this screen!'
I have had a couple of customers using opera and firefox say that it hung on the greyed out screen and they didn't know if the order was processing or not.
Zen Follower
lat9:
The "thing" is that the billing address is always required, but the shipping address (think 'virtual products') isn't. That's why the billing address is displayed first.
I see your point now. Indeed, for virtual/digital product, shipping address is not needed.
zennedOut
Nick1973:
There still appears to be a problem for me with the Square Web Pay Module.
I get the SQ-MSCONF error with Square after installing OPC, but if I edit jquery.checkout_one.js as suggested by carlwhat here https://www.zen-cart.com/showthread.php?228750-Square-WebPay-support-thread&p=1387913#post1387913
It works.
One thing I have noticed is that once the 'Confirm Order' button is clicked, it hangs on the greyed out screen. Which can be confusing to customers. If it needs to do that while processing, maybe it should have a notice pop up something like 'Please Wait, Order Processing. Do not close this screen!'
I have had a couple of customers using opera and firefox say that it hung on the greyed out screen and they didn't know if the order was processing or not.
i know this is a long thread, but i would encourage trying to read all of it.
lat9 incorporated my changes into version 2.4.0, which is the latest version available for download on the plugins.
please confirm you are running that version and still having problems without corrections.
with regards to the confirm order button click, there already is a spinning gif. it is located here:
includes/templates/template_default/images/confirmation_one_loading.gif
do you not have that file? does it not show up when one clicks confirm order?
that spinning gif is also easily replaceable by any of the numerous ones available on the internet. an internet search such as these returns results:
https://tinyurl.com/y57y5pd6
https://uxplanet.org/using-loading-animation-on-websites-and-apps-examples-and-snippets-to-use-cab0097be9f1
downloading this one, renaming it, and putting it in the right place will certainly have your customers talking (MO):
https://i.pinimg.com/originals/83/2f/cc/832fcc0470eea708f1b6bb2caeaa6145.gif
best.
Totally Zenned
carlwhat:
i know this is a long thread, but i would encourage trying to read all of it.
lat9 incorporated my changes into version 2.4.0, which is the latest version available for download on the plugins.
please confirm you are running that version and still having problems without corrections.
with regards to the confirm order button click, there already is a spinning gif. it is located here:
includes/templates/template_default/images/confirmation_one_loading.gif
do you not have that file? does it not show up when one clicks confirm order?
that spinning gif is also easily replaceable by any of the numerous ones available on the internet. an internet search such as these returns results:
https://tinyurl.com/y57y5pd6
https://uxplanet.org/using-loading-animation-on-websites-and-apps-examples-and-snippets-to-use-cab0097be9f1downloading this one, renaming it, and putting it in the right place will certainly have your customers talking (MO):
https://i.pinimg.com/originals/83/2f/cc/832fcc0470eea708f1b6bb2caeaa6145.gif
best.
I am running Zen Cart 1.5.7d and OPC 2.4.0
Your changes weren't in the download so I had to manually change them. I have another problem now, but will speak to lat9 about that in a separate post on here as I don't think it is square related.
Totally Zenned
Cindy, I have installed OPC 2.4.0 on Zen Cart 1.5.7d
When I get to the Checkout page and enter all my details, then click 'Save Changes' nothing happens and everything remains greyed out. All the details are entered correctly as well.
There is a box on the right of the screen that says 'Bottom Instructions', but it has nothing in it.
I have attached an image.
Also when I turn OPC off and use the default checkout, that works ok.I have a DEBUG file, but I would need to send it to you as it contains personal information. So can I'll send this by PM.
Totally Zenned
Nick1973:
Cindy, I have installed OPC 2.4.0 on Zen Cart 1.5.7d
When I get to the Checkout page and enter all my details, then click 'Save Changes' nothing happens and everything remains greyed out. All the details are entered correctly as well.
There is a box on the right of the screen that says 'Bottom Instructions', but it has nothing in it.
I have attached an image.
Also when I turn OPC off and use the default checkout, that works ok.I have a DEBUG file, but I would need to send it to you as it contains personal information. So can I'll send this by PM.
The DEBUG file is too long to send in a PM so I have emailed it to you.
Totally Zenned
Note that 2.4.0 was approved on the 2nd of May.
Many github changes were made after that date that make required corrections for OPC and Square WebPay to play nice.
NOTE: Just looked and there is one more spot that needs to be changed. I've submitted a pull request.
With the existing changes and the change in the pull request, OPC and Square WebPay are working in harmony on all our sites that use both.
zennedOut
dbltoe:
Note that 2.4.0 was approved on the 2nd of May.
Many github changes were made after that date that make required corrections for OPC and Square WebPay to play nice.
i do not believe this to be correct...
the only file that needed modification was jquery.checkout_one.js and its minimized version. that file was last modified on 4/22/2022, as seen here:
the 2.4.0 release added a new configuration value for the submit button function. leaving that config value as its default value would ensure proper integration with square_webPay.
being that i am the author of square_webPay and was involved with lat9's change to OPC so that they 2 plugins work well together, i stand by my assertion that 2.4.0 should work properly with square_webPay with no further modification.
best.
Totally Zenned
Please see issue #328 and #331
With just #328's corrections, our sites were getting the OPC circular warning AND the line 234 error for Square WebPay. Making the change in #331 stopped both the OPC logs and the Square logs.
No glitches for two days now.
zennedOut
dbltoe:
Please see issue #328 and #331
With just #328's corrections, our sites were getting the OPC circular warning AND the line 234 error for Square WebPay. Making the change in #331 stopped both the OPC logs and the Square logs.
No glitches for two days now.
that is not unique to square_webPay. square_webPay merely exposed that bug which was already there.
Totally Zenned
just so we are clear
And, since you said you didn't want to be bothered, it's not on the WebPay thread.
BUT... Anyone using OPC with WebPay needs to be aware of what is needed for them to operate correctly.
Or, do you disagree?
Totally Zenned
carlwhat:
that is not unique to square_webPay. square_webPay merely exposed that bug which was already there.
Right, ok so now I am even more confused....but don't take offence guys :D
Where is the version of OPC that actually works please? And if there is an update to 2.4.0 somewhere, it obviously needs resubmitting as I won't be the only person having issues. :smile:
zennedOut
dbltoe:
And, since you said you didn't want to be bothered, it's not on the WebPay thread.
BUT... Anyone using OPC with WebPay needs to be aware of what is needed for them to operate correctly.
Or, do you disagree?
man, this is like an old school flame war from usenet.
i was responding to nick1973 problem that he needed to apply my changes to the javascript. and was responding to that specific issue.
but hey if you want to continue whatever it is that you think you are doing, feel free.
i'm sure i can find other situations worthy of my coding skills.
best.
Totally Zenned
carlwhat:
man, this is like an old school flame war from usenet.
i was responding to nick1973 problem that he needed to apply my changes to the javascript. and was responding to that specific issue.
but hey if you want to continue whatever it is that you think you are doing, feel free.
i'm sure i can find other situations worthy of my coding skills.
best.
Is it like pulling teeth carlwhat? :D
Right, so can we get this down in simple terms please.
So this is the post that I used to make changes to jquery.checkout_one.js
https://www.zen-cart.com/showthread.php?228750-Square-WebPay-support-thread&p=1387913#post1387913
these two changes appear to make the squarepay module work, although I think there might have been issues in opera and firefox with it hanging on the checkout page before the payment is taken for some reason. It's just that when it does that, the animated gif does not immediately appear. The screen just fades and takes a while to pull the gif up. It may also depend on internet connections.
My other issue is that for some reason on two sites, the Save Changes Button does not work.
Totally Zenned
Those changes were made before even 2.4.0.
The WebPay from the plugins and the files from lat9's github (including the pull request for #331) are the files needed to work with 1.5.6c=> and PHP 7.3.3=>.
Totally Zenned
dbltoe:
Those changes were made before even 2.4.0.
The WebPay from the plugins and the files from lat9's github (including the pull request for #331) are the files needed to work with 1.5.6c=> and PHP 7.3.3=>.
Ok well I have all that installed. I have successfully installed one page checkout and Square Web Pay on another site this evening. So I need to work out what is different on the other two sites that I mentioned are having a problem. They are all 1.5.7d running the latest of OPC with the changes and Square Web Pay. And on PHP 7.4.
I am getting this issue though in the logs.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:567]
#2 OnePageCheckout->startGuestOnePageCheckout() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:41]
#3 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 567.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:567]
#2 OnePageCheckout->startGuestOnePageCheckout() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:41]
#3 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 567.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:744]
#2 OnePageCheckout->updateOrderAddresses() called at [/home/MYSITE/public_html/includes/classes/observers/class.checkout_one_observer.php:422]
#3 checkout_one_observer->update() called at [/home/MYSITE/public_html/includes/classes/class.base.php:118]
#4 base->notify() called at [/home/MYSITE/public_html/includes/classes/order.php:425]
#5 order->cart() called at [/home/MYSITE/public_html/includes/classes/order.php:35]
#6 order->__construct() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:158]
#7 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 744.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:744]
#2 OnePageCheckout->updateOrderAddresses() called at [/home/MYSITE/public_html/includes/classes/observers/class.checkout_one_observer.php:422]
#3 checkout_one_observer->update() called at [/home/MYSITE/public_html/includes/classes/class.base.php:118]
#4 base->notify() called at [/home/MYSITE/public_html/includes/classes/order.php:425]
#5 order->cart() called at [/home/MYSITE/public_html/includes/classes/order.php:35]
#6 order->__construct() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:158]
#7 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 744.
Totally Zenned
If you are getting those issues, you are not using the files from github. Go to https://github.com/lat9/one_page_checkout, click on the Green CODE button and download the zip.
There are some changes in the admin files that need to be made for WebPay to work with some shipping modules AND some changes in files inside the includes folder to fix the var_export problem.
The errors you reported were fixed with the fix for #328 and ARE included in the download zip file.
You can fix the third var_export mentioned in the Pull Request either before or after you upload all the files. If you don't do the fix, you will get yet another var_export error for line 784 of includes/cllasses/observers/class.checkout_one_observer.php.
You can just overrite the existing files on your site and it wil work fine.
Totally Zenned
dbltoe:
If you are getting those issues, you are not using the files from github. Go to https://github.com/lat9/one_page_checkout, click on the Green CODE button and download the zip.
There are some changes in the admin files that need to be made for WebPay to work with some shipping modules AND some changes in files inside the includes folder to fix the var_export problem.
The errors you reported were fixed with the fix for #328 and ARE included in the download zip file.
You can fix the third var_export mentioned in the Pull Request either before or after you upload all the files. If you don't do the fix, you will get yet another var_export error for line 784 of includes/cllasses/observers/class.checkout_one_observer.php.
You can just overrite the existing files on your site and it wil work fine.
Right well this is obviously where I am getting confused and other people will get confused. So obviously this needs putting in 'Plugins' asap really as not everyone is aware they will exist there. Now I know which ones I should be using, I will go and get them though.
Fields marked required must be completed.
Tell staff why this post should be reviewed.