QuickBooks Merchant Service

correct, im sure it still is config issues....i just need to figure out what config files its referencing...i was hopping my error logging tool would be able to at least give some input, but it doesnt even log the issue. :(

thanks again cptook...you are the man or woman?

cptook, I installed your 1.7a version and I love it. Great job.
The posting back to the order in Zen works and is exactly what I was looking for. :clap:

Make sure you submit 1.7a for the download section. Now the naming of this thread should be edited to have the BETA removed!

cptook, great job on keeping this alive!

So, I installed a fresh version of zencart on another domain and added only the quickbooks module to it, and sure enough that red box pops up.

i replaced the core files that you said drives that red box, with fresh ones and it didnt change anything...I know you've done a ton already, but do you think you could give me some hints on where to look for problems?

Dr. Byte looked at my configure.php files, and didnt notice anything that would cause the red box to not pop up....I was thinking since you know this module inside and out now...you might be able to point me at some other files to look at?

Thanks again, and again, and again!

Hi Securfocus -

Try this. Look at around line 158 of qbms.php in includes/modules/payment/qbms.php

Find these two lines (I prefer to use quote rather than code so you can see the whole line - but these are only TWO lines):

$payment_error_return = 'payment_error=' . $this->code . '&error=' . urlencode($error) . '&qbms_cc_owner=' . urlencode($_POST['qbms_cc_owner']) . '&qbms_cc_expires_month=' . $_POST['qbms_cc_expires_month'] . '&qbms_cc_expires_year=' . $_POST['qbms_cc_expires_year'];

zen_redirect(zen_href_link(FILENAME_CHECKOUT_PAYMENT, $payment_error_return, 'SSL', true, false));

Replace with the following two lines (or you can comment them out if you like and just add these two lines):

$messageStack->add_session('checkout_payment', $error, 'error');

zen_redirect(zen_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL', true, false));

This is in fact the right way to do it with current Zen Cart specs, so this is now added to update when/if another release happens. Just wondering if in your case, this helps with the broken URL. Worth a try anyway?

Mydanilo - you should apply this change - or download 1.7c from "you know where"!! :)

Yep, done. Thanks.

that did it! You are awsome!!!

did you post up 1.7c...or is that still in "beta"

Thanks again...you are saving my life! LOL!

Securfocus - I'm so glad that did it for you. I suspected it might be that. I have not posted 1.7c as I don't want to put up too many releases with little fixes along the way. I'm waiting to roll up all that's been done, along with some additional code cleanup - and post it as 1.8 stable release. In the meantime - like mydanilo, if you PM me, I'll give a link to current minor releases.

Just a head's up. After the catch with error reporting, the entire module was updated to include the correct code in all error reporting. Also, all of the code and formatting clean up was done, so we may just about be at a 1.8 stable version to post. Unless someone finds something else amiss with the module - it appears that we are, finally, in pretty good shape! Once again, my thanks to the posters here for providing the prompt feedback to get this all done. As a production user myself, this has all been very worthwhile!

Mydanilo and securfocus - if you'd like to make sure 1.8 is good - I'd appreciate you both testing in your production environments to make sure I haven't missed something prior to uploading the addon site. PM me for link.

That PM i sent you may not be relevant to anything you did...so just disregard it for right now, and let me test something else...

THanks cptook

Installed 1.8 and will report back once I see orders posted. So far looks good but did not complete live transactions yet.

In fact - I think I did miss a global call. So error reporting in other places may not work. Fixing now. This is what Securfocus noticed with a declined card.

I'm doing a quick test - and will repost version. Actually, this was a very silly oversight.... <sigh>

Fixed - please redownload 1.8. Securfocus, this should fix your error. Sorry, small mistake.

Ok, so I did get the same error.

Secur - you are getting the same error WITH the new file? Is it the same error (the add_session error)?

Fixed...thank you!!!

Nope, that updated fixed it!

Excellent. I think we're in good shape.

I have a problem with 1.8. When a card gets rejected by qb processing, it just hangs on a blank screen. No rejection message gets back to zencart. I will re-upload a older version and see if it works.

Test result: 1.7c works. Return correctly back to the checkout screen with the error message: Your credit card was declined. Please try another card or contact your bank for more info.

1.8 does not, just hangs if payment does not get approved.

Mydanilo - see above (post 191). Did you redownload 1.8 after the first try? It was changed - specifically in that error handling code. I had missed a small item. Please try that and report back.

Nope I did not. So 1.8 is not = 1.8, I assume that some modifications were added after I downloaded. I will do it again and let you know. Tanks.

Correct, global $messageStack; was added. So I re-uploaded and hope it is now working.