Stop Disabled Products From Showing in New Products for Category?

[Ajeh]

Compare the original code from:
/includes/modules/new_products.php

with your templates and overrides:
/includes/modules/your_template_dir/new_products.php

Do they both have the products_status = 1 in both SELECT statements?

[bigdiogi]

Compare the original code from:
/includes/modules/new_products.php

with your templates and overrides:
/includes/modules/your_template_dir/new_products.php

Do they both have the products_status = 1 in both SELECT statements?

Thought I answered both of these questions in my earlier reply.

There IS no second version of the file in /includes/modules/my_template_dir/new_products.php

File is ONLY located in default template location.

There is no products_status = 1 in the second SELECT statement. So how do I remedy that? Do I insert it? How so do I do that without messing up the syntax of the query?

Keep in mind I am totally ignorant about php and SQL languages.

[bigdiogi]

Always try to keep my posts concise, Perhaps that sometimes makes them unnecessarily cryptic. Here are the lines of code I believe you are referring to -

if ( (($manufacturers_id > 0 && $_GET['filter_id'] == 0) || $_GET['music_genre_id'] > 0 || $_GET['record_company_id'] > 0) || (!isset($new_products_category_id) || $new_products_category_id == '0') ) {
  $new_products_query = "select distinct p.products_id, p.products_image, p.products_tax_class_id, pd.products_name,
                                p.products_date_added, p.products_price, p.products_type, p.master_categories_id
                           from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd
                           where p.products_id = pd.products_id
                           and pd.language_id = '" . (int)$_SESSION['languages_id'] . "'
                           and   p.products_status = 1 " . $display_limit;
} else {
  // get all products and cPaths in this subcat tree
  $productsInCategory = zen_get_categories_products_list( (($manufacturers_id > 0 && $_GET['filter_id'] > 0) ? zen_get_generated_category_path_rev($_GET['filter_id']) : $cPath), false, true, 0, $display_limit);

  if (is_array($productsInCategory) && sizeof($productsInCategory) > 0) {
    // build products-list string to insert into SQL query
    foreach($productsInCategory as $key => $value) {
      $list_of_products .= $key . ', ';
    }
    $list_of_products = substr($list_of_products, 0, -2); // remove trailing comma

    $new_products_query = "select distinct p.products_id, p.products_image, p.products_tax_class_id, pd.products_name,
                                  p.products_date_added, p.products_price, p.products_type, p.master_categories_id
                           from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd
                           where p.products_id = pd.products_id
                           and pd.language_id = '" . (int)$_SESSION['languages_id'] . "'
                           and p.products_id in (" . $list_of_products . ")";
  }
}

If I'm following you correctly, I need to add a reference to p.products_status = 1 " to the end of the second SELECT query. Exactly how should I do that? What is the correct syntax? Should I just copy and paste

 and   p.products_status = 1 " . $display_limit;

before the } ?

[Ajeh]

You have me confused ...

In v1.3.9h the version id reads:

 * @version $Id: new_products.php 8730 2008-06-28 01:31:22Z drbyte $

yet you say you are using v1.3.9h and not v1.3.8 yet you are showing the code for v1.3.8 ...

[bigdiogi]

Well, that makes two of us that are confused . Downloaded zen-cart-v1.3.9h-full-fileset-10262010.zip on 2/05/2011. Just checked that, still have the zip file. Extracted the archive. It's the only copy of zencart on a fairly new laptop with no clutter or old files laying around. Installed as per directions. But when I just checked version info in admin, shows Zen Cart 1.3.8a.

How in the XXX?! I've been operating under the delusion that I actually installed the version I downloaded. POLTERGEIST!

'Splains the issue though, huh? A known bug in 1.3.8.

[Ajeh]

Hate when the gremlins strike ...

I would redo the site with v1.3.9h before you get much further as that v1.3.8 is very old and very buggy and has a lot of security issues that were addressed in v1.3.9 ...