One-Page Checkout [Support Thread]

lat9:

@BillJ, thanks for that. While the inclusion of the "Shipping, same as billing" checkbox is as expected (I ***do ***need to update that demo site), the inclusion of the blocks other than the shopping-cart (i.e. current products) list should not be displayed until the addresses have been validated. I'll open an issue on the OPC GitHub repository to track the change(s) required.
Found it! That was an overly-aggressive change for this issue. Edit your template's version of checkout_one.css, changing the line that reads

.opc-overlay .active { background: #dcdcdc; height: 100%; width: 100%; opacity: 0.5; top: 0; left: 0; position: absolute; padding: 0; z-index: 1; }

to

[B].opc-overlay.active[/B] { background: #dcdcdc; height: 100%; width: 100%; opacity: 0.5; top: 0; left: 0; position: absolute; padding: 0; z-index: 1; }

... removing that intervening space between .opc-overlay and .active.

Thank you! That has fixed it and everything appears to be working as expected. I appreciate the help.

ZC v1.5.7c
Bootstrap 4 v3.1.2
OPC v2.3.8

City autofill error was re-introduced to Guest Checkout after installing OPC. (reference: https://www.zen-cart.com/showthread.php?223910-ZCA-Bootstrap-4-Template-Support-Thread&p=1381737#post1381737)

I believe I need to apply the specificity fix (https://github.com/zencart/zencart/commit/b9efe5fa9ad5bf0f7ee82fa4fe2399671adb6ed4) to the following file which is listed under new files in the Read Me but not included in the download:

77. /includes/templates/YOUR_TEMPLATE/css/create_account.css

Though my eyes might be playing tricks on me.

RoseStar:

ZC v1.5.7c
Bootstrap 4 v3.1.2
OPC v2.3.8

City autofill error was re-introduced to Guest Checkout after installing OPC. (reference: https://www.zen-cart.com/showthread.php?223910-ZCA-Bootstrap-4-Template-Support-Thread&p=1381737#post1381737)

I believe I need to apply the specificity fix (https://github.com/zencart/zencart/commit/b9efe5fa9ad5bf0f7ee82fa4fe2399671adb6ed4) to the following file which is listed under new files in the Read Me but not included in the download:

Though my eyes might be playing tricks on me.
@RoseStar, you're correct on both points. I'll be opening issues on GitHub for both the base One-Page Checkout and the Bootstrap-4/OPC integration plugins to get that specificity correction pulled in.

I've come up against another issue with OPC. Whenever I try to confirm an order, I end up back on the checkout page with the message:
"Your order's details have changed. Please review the current values and re-submit."

I can see the reason for the message. I have one product in the cart (I have tried with different products and with multiple products) and the total value of goods is £13.55.
However, the subtotal (including tax) is showing as £13.26 inc. tax, plus postage.
The tax rate is 20% so that doesn't account for the difference and I have set the rate to zero and the discrepancy was still there. I have a couple of OT modules that could possibly affect the total but I have avoided products that would bring them in and none of them are listed on the checkout page.

I have had to put the site live today with OPC disabled but if anyone wants to take a look, please PM me for test credentials and I'll add a test user to the OPC conditional-enable list (what an excellent debugging feature!).

BillJ:

I've come up against another issue with OPC. Whenever I try to confirm an order, I end up back on the checkout page with the message:
"Your order's details have changed. Please review the current values and re-submit."

I can see the reason for the message. I have one product in the cart (I have tried with different products and with multiple products) and the total value of goods is £13.55.
However, the subtotal (including tax) is showing as £13.26 inc. tax, plus postage.
The tax rate is 20% so that doesn't account for the difference and I have set the rate to zero and the discrepancy was still there. I have a couple of OT modules that could possibly affect the total but I have avoided products that would bring them in and none of them are listed on the checkout page.

I have had to put the site live today with OPC disabled but if anyone wants to take a look, please PM me for test credentials and I'll add a test user to the OPC conditional-enable list (what an excellent debugging feature!).

You don't say which version of OPC, but starting with v2.3.5 there's a SuperUser-only admin file that can help determine what's going on in these re-direct loops: /admin/opc_debug_redirection_error.php ... documentation for its use: https://github.com/lat9/one_page_checkout/blob/master/pages/debugging_redirect.md

lat9:

You don't say which version of OPC, but starting with v2.3.5 there's a SuperUser-only admin file that can help determine what's going on in these re-direct loops: /admin/opc_debug_redirection_error.php ... documentation for its use: https://github.com/lat9/one_page_checkout/blob/master/pages/debugging_redirect.md
Thank you very much. It is OPC 2.3.8. I'll check out that tool this evening and hopefully get to the bottom of it.

I've just submitted v2.3.9 of One-Page Checkout for the Zen Cart moderators' review; I'll post back here when it's available for download.

 This release contains changes associated with the following GitHub issues:

#295: Correct ambiguous coupon_id on account registration (MySQL error)
#296: Correcting greedy CSS change in v2.3.6, resulting in items showing that should be blocked.
#297: Add address-fields' 'specificity' to correct browser address-autofills.

lat9:

I've just submitted v2.3.9 of One-Page Checkout for the Zen Cart moderators' review; I'll post back here when it's available for download.

 This release contains changes associated with the following GitHub issues:

#295: Correct ambiguous coupon_id on account registration (MySQL error)
#296: Correcting greedy CSS change in v2.3.6, resulting in items showing that should be blocked.
#297: Add address-fields' 'specificity' to correct browser address-autofills.
Available for download: https://www.zen-cart.com/downloads.php?do=file&id=2095

I was totally up to date with the last release. As I read in the installation procedure, this is just a drop in/overwrite of the previous version for 1.5.7c, correct?

g2ktcf:

I was totally up to date with the last release. As I read in the installation procedure, this is just a drop in/overwrite of the previous version for 1.5.7c, correct?
Correct, it's a drop-in update. Just check the change history, I'm pretty good about identifying the files that have changed.

First thank you for the plugin, it's a great idea :)
I am however having a problem with it.
I have a new install of Zen Cart v1.5.7c running responsive template on PHP 7.4.21 and only a handful of plugins installed.
I have two flat rate shipping modules installed (Regular & Express) after cloning the Flat rate module.
Whenever I go to checkout, I click on the radio dot of the "Standard Flat Rate" under shipping method but the screen quickly refreshes and the shipping method options disappear (view below snapshots) and can't confirm order as it will come up with error when I click on the confirm order button?!
I checked the error log and the below code is at the bottom of the log, can't really figure out the issue, I've had to turn off the one checkout module for now, the checkout process works fine in normal checkout mode, no such issues?!

(Please view snapshots below):
BEFORE pressing the radio button: https://i.imgur.com/D5tYjwq.png
AFTER (error) clicking on the radio button: https://i.imgur.com/Ogd7nIW.png
AFTER (error) clicking on the Confirm Order Button: https://i.imgur.com/htIzRAG.png

Wonder why it's doing this? I hope I can get some assistance.
Thank you.

2021-07-25 15:41:34 index: updateShipping, returning:{"status":"invalid","errorMessage":"Your available shipping options have changed. Please re-select your desired shipping method.","orderTotalHtml":"<div id=\"otsubtotal\">\r\n    <div class=\"totalBox larger forward\">$7.00<\/div>\r\n    <div class=\"lineTitle larger forward\">Sub-Total:<\/div>\r\n<\/div>\r\n<br class=\"clearBoth\" \/>\r\n<div id=\"ottotal\">\r\n    <div class=\"totalBox larger forward\">$7.00<\/div>\r\n    <div class=\"lineTitle larger forward\">Total:<\/div>\r\n<\/div>\r\n<br class=\"clearBoth\" \/>\r\n","shippingHtml":"","shippingMessage":"","paymentHtml":"<!--bof payment-method choices -->\n  <div id=\"checkoutPaymentMethod\" class=\"floatingBox forward clearRight\">\n    <fieldset>\n      <legend>Payment Method<\/legend>\n<div class=\"custom-control custom-radio\"><input type=\"hidden\" name=\"payment\" value=\"dirbankaus\" id=\"pmt-dirbankaus\" \/>      <label for=\"pmt-dirbankaus\" class=\"custom-control-label radioButtonLabel\">Bank Deposit\/Internet Transfer<div id=\"bankpayment\"><img src=\"images\/bankpayment.jpg\" alt=\"\" \/><\/a><\/div><\/label>\n      <\/div>\n      <br class=\"clearBoth\" \/>\n\n    <\/fieldset>\n  <\/div>\n  <div class=\"clearBoth\"><\/div>\n<!--eof payment-method choices -->\n","paymentHtmlAction":"update"}
Shipping not set

@rlexyd, are there any debug-logs generated during that checkout?

What is the file-name of your flat-rate clone shipping method? If you (temporarily) disable that shipping-method clone and enable one of the other built-in shipping modules for testing, does the issue 'disappear'.

I am, as you can derive, trying to see if it's that clone that is giving you grief.

Hi,Thanks for helping.
No, the only thing that occurs is the (one_page_checkout error log gets bigger) and the bottom of it shows the error I included in last post, not sure if you need to see any other info from that log.
First I disabled the Express Module, error still came up,
Than I disabled Flat Module, error still came up again,
After I disabled BOTH shipping modules and only left "Store Pick Up" as an option but that came up with a Different error now and the following debug log:

[26-Jul-2021 08:03:12 Australia/Sydney] PHP Notice:  Malformed value for session-based shipping module; customer will need to re-select: false in /home2/...../public_html/....com.au/includes/classes/order.php on line 323

Error snapshot: https://i.imgur.com/313GGoE.png

Weird all this seem to happen when the one_checkout is enabled.

My flat rate file names are (flat.php and express.php), I've checked both files well and they are ok, and they both work fine in normal zen cart checkout process.

On another note, been trying to take out the brackets from the shipping module, I managed to do it in normal checkout, but can't seem to figure it out in (one checkout mode), as when I take out the ( checkout process goes blank?! All I did was just Remove the parens themselves from between the apostrophes from the codes below:

This is the file I deleted just the parens from (includes/modules/pages/checkout_one/header_php.php) on two separate lines.

if ($_SESSION['shipping']['cost'] == $method['cost'] && $_SESSION['shipping']['title'] == ($val['module'] . ' [B]([/B]' . $method['title'] . '[B])[/B]')) {

'title' => $quotes[0]['title'] . ' [B]([/B]' . $quotes[0]['methods'][0]['title'] . '[B])[/B]', 

This is the file I deleted just the parens from (includes/modules/pages/checkout_one_confirmation/header_php.php) on one line.

'title' => ($free_shipping) ?  $quote[0]['methods'][0]['title'] : ($quote[0]['module'] . ' [B]([/B]' . $quote[0]['methods'][0]['title'] . '[B])[/B]'),

One more thing I just noticed..
Ok, so when I have the one checkout enabled and have the two flat rate shipping options available..
As per the usual error from previous post, if I click on the already chosen radio button on the standard flat rate shipping, I get that error where all shipping modules disappear, and if I refresh, they come back, than when I click again, the loading circle hovers over the radio button and they disappear again, then when I hit refresh again, they come back....
NOW, if I click the express flat rate radio button, no error occurs, it chooses that button correctly, than if I click the regular standard flat rate radio button, it works fine and I can go to the checkout correctly.

VERY weird that's for sure, but it might help someone understand the issue a bit more at least?!

Agreed, it's pretty weird. Just checking; what version of OPC is in use?

I installed 2.3.8 but updated to 2.3.9 to see if it fixes the problem (I just merged/uploaded the 5 files that were changed) but the problem is still there?!

An odd error occurred overnight where an error in OPC caused duplicate orders 22 seconds apart for the same customer and same items, but did not send out any order conformation emails. Only one of the orders was charged out (PayPal) with no payment confirmation visible in admin, but shows in PayPal.

Same error posted to the log for both orders.

Error Log:

[26-Jul-2021 21:31:26 America/Chicago] Request URI: /store/index.php?main_page=checkout_process, IP address: xx.38.xx.8
#1 trigger_error() called at [/includes/classes/OnePageCheckout.php:1399]
#2 OnePageCheckout->inputPreCheck() called at [/includes/classes/OnePageCheckout.php:898]
#3 OnePageCheckout->formatAddress() called at [/includes/classes/observers/class.checkout_one_observer.php:532]
#4 checkout_one_observer->update() called at [/includes/classes/class.base.php:118]
#5 base->notify() called at [/includes/classes/order.php:1183]
#6 order->send_order_email() called at [/includes/modules/checkout_process.php:103]
#7 require(/includes/modules/checkout_process.php) called at [/includes/modules/pages/checkout_process/header_php.php:14]
#8 require(/includes/modules/pages/checkout_process/header_php.php) called at [/index.php:35]
--> PHP Fatal error: Invalid request, tempAddressValues not set. in /includes/classes/OnePageCheckout.php on line 1399.

1.5.7 store
OPC v2.3.8
Bootstrap 4 template

Going to update to OPC v2.3.9 today...

rlexyd:

I installed 2.3.8 but updated to 2.3.9 to see if it fixes the problem (I just merged/uploaded the 5 files that were changed) but the problem is still there?!
If you'd post a zip of the two shipping modules, I can take a look to see if I can see something awry.